* [PATCH] signal: remove unused variable
@ 2017-09-14 2:44 Dmitry V. Levin
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry V. Levin @ 2017-09-14 2:44 UTC (permalink / raw)
To: Al Viro
Cc: Stephen Rothwell, Linux-Next Mailing List,
Linux Kernel Mailing List
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 9b24ec57688a ("get_compat_sigset()")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
kernel/signal.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index 3198a7d2e5ff..36a523640894 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -3440,7 +3440,6 @@ COMPAT_SYSCALL_DEFINE4(rt_sigaction, int, sig,
if (act) {
compat_uptr_t handler;
- compat_sigset_t mask;
ret = get_user(handler, &act->sa_handler);
new_ka.sa.sa_handler = compat_ptr(handler);
#ifdef __ARCH_HAS_SA_RESTORER
--
ldv
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] signal: remove unused variable
@ 2017-09-11 20:03 Arnd Bergmann
2017-09-14 7:36 ` Christos Gkekas
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-09-11 20:03 UTC (permalink / raw)
To: Al Viro; +Cc: Arnd Bergmann, linux-kernel
The get_compat_sigset() cleanup missed a variable that is now unused:
kernel/signal.c: In function 'C_SYSC_rt_sigaction':
kernel/signal.c:3443:19: error: unused variable 'mask' [-Werror=unused-variable]
Fixes: 9b24ec57688a ("get_compat_sigset()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
kernel/signal.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index 3198a7d2e5ff..36a523640894 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -3440,7 +3440,6 @@ COMPAT_SYSCALL_DEFINE4(rt_sigaction, int, sig,
if (act) {
compat_uptr_t handler;
- compat_sigset_t mask;
ret = get_user(handler, &act->sa_handler);
new_ka.sa.sa_handler = compat_ptr(handler);
#ifdef __ARCH_HAS_SA_RESTORER
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] signal: remove unused variable
2017-09-11 20:03 Arnd Bergmann
@ 2017-09-14 7:36 ` Christos Gkekas
0 siblings, 0 replies; 3+ messages in thread
From: Christos Gkekas @ 2017-09-14 7:36 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Al Viro, linux-kernel
On 11/09/17 22:03:37 +0200, Arnd Bergmann wrote:
> The get_compat_sigset() cleanup missed a variable that is now unused:
>
> kernel/signal.c: In function 'C_SYSC_rt_sigaction':
> kernel/signal.c:3443:19: error: unused variable 'mask' [-Werror=unused-variable]
>
> Fixes: 9b24ec57688a ("get_compat_sigset()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> kernel/signal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 3198a7d2e5ff..36a523640894 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -3440,7 +3440,6 @@ COMPAT_SYSCALL_DEFINE4(rt_sigaction, int, sig,
>
> if (act) {
> compat_uptr_t handler;
> - compat_sigset_t mask;
> ret = get_user(handler, &act->sa_handler);
> new_ka.sa.sa_handler = compat_ptr(handler);
> #ifdef __ARCH_HAS_SA_RESTORER
> --
> 2.9.0
>
Thanks,
Acked-by: Christos Gkekas <chris.gekas@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-14 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-14 2:44 [PATCH] signal: remove unused variable Dmitry V. Levin
-- strict thread matches above, loose matches on Subject: below --
2017-09-11 20:03 Arnd Bergmann
2017-09-14 7:36 ` Christos Gkekas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox