RE: keyboard backlight max_brightness bug on Dell Latitude E6410

RE: keyboard backlight max_brightness bug on Dell Latitude E6410

[Gabriel M. Elder]

output from smbios-keyboard-ctl --info:

Libsmbios version : 2.3.0
smbios-keyboard-ctl version : 2.3.0

 Capabilities of KeyBoard Illumination on your system: 
-------------------------------------------------------------------
 Supported USER Selectable Modes : 
	 Always OFF
	 Auto: ALS- and input-activity-based On; input-activity based Off
	 Auto: Input-activity-based On; input-activity based Off

 Supported Keyboard illumination type :  Backlight

 Supports Keyboard illumination on : 
	Any Keystroke
	Touchpad activity
	Pointing stick

 Can configure Keyboard illumination timeout unit in : 
	Seconds
	Minutes
	Hours

 Supported Keyboard light brightness levels :  10

 Maximum acceptable seconds timeout value   :  255

 Maximum acceptable minutes timeout value   :  255

 Maximum acceptable hours timeout value     :  12

 Maximum acceptable days timeout value      :  0


output from smbios-keyboard-ctl --get-status:

Helper function to print current status of keyboard illumination

 Current status of KeyBoard Illumination setting on your system: 
-------------------------------------------------------------------

 Configured mode state: 
	 Auto: Input-activity-based On; input-activity based Off

 Your Keyboard will illumination on: 
	Any Keystroke
	Touchpad activity
	Pointing stick

 Keyboard illumination timeout has bee set at: 10  Seconds

 Current setting of ALS value that turns the light on or off: 18
 Current ALS Reading : 16
 Current keyboard light level : 9


-------- Original Message --------
Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
E6410
From: Pali Rohár <pali.rohar@gmail.com>
Date: Thu, September 14, 2017 3:06 am
To: "Gabriel M. Elder" <gabriel@tekgnowsys.com>
Cc: dvhart@infradead.org, andy@infradead.org,
platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org

On Monday 11 September 2017 23:25:27 Gabriel M. Elder wrote:
> Hi all,
> Hans de Goede, one of the upower maintainers, suggested I alert you all to this bug:
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=100041
> 
> and the new one I filed via the kernel bugzilla:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=196913
> "keyboard backlight max_brightness value outside allowable range on Dell Latitude E6410 laptop"
> 
> Please check it out at your earliest convenience.
> 
> thanks,
> - Gabriel</html>

Hi Gabriel, please avoid sending such html emails to mailing list as it
is hard to read them and also you have a very big chance that email
would be eaten by spam filter or other developers would completely
ignore it...

To debug your problem, can you run smbios-keyboard-ctl tool from the
libsmbios project? https://github.com/dell/libsmbios

We would need output from --info parameter and also from --get-status.

-- 
Pali Rohár
pali.rohar@gmail.com

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

[Pali Rohár]

Adding Gabriele to thread, IIRC you have machine which uses
"supported keyboard light brightness levels"
Can you look at this bug, if your machine is affected by it too?

Important parts in ouptput:

> ... --info
>  Supported Keyboard light brightness levels :  10

> ... --get-status
>  Current keyboard light level : 9

Gabriel, can you play with this tool, which values can be set via
--set-level= parameter? Is 10 accepted? --get-status can be used to
check if value was accepted.

On Thursday 14 September 2017 06:35:15 Gabriel M. Elder wrote:
> 
> output from smbios-keyboard-ctl --info:
> 
> Libsmbios version : 2.3.0
> smbios-keyboard-ctl version : 2.3.0
> 
>  Capabilities of KeyBoard Illumination on your system: 
> -------------------------------------------------------------------
>  Supported USER Selectable Modes : 
> 	 Always OFF
> 	 Auto: ALS- and input-activity-based On; input-activity based Off
> 	 Auto: Input-activity-based On; input-activity based Off
> 
>  Supported Keyboard illumination type :  Backlight
> 
>  Supports Keyboard illumination on : 
> 	Any Keystroke
> 	Touchpad activity
> 	Pointing stick
> 
>  Can configure Keyboard illumination timeout unit in : 
> 	Seconds
> 	Minutes
> 	Hours
> 
>  Supported Keyboard light brightness levels :  10
> 
>  Maximum acceptable seconds timeout value   :  255
> 
>  Maximum acceptable minutes timeout value   :  255
> 
>  Maximum acceptable hours timeout value     :  12
> 
>  Maximum acceptable days timeout value      :  0
> 
> 
> output from smbios-keyboard-ctl --get-status:
> 
> Helper function to print current status of keyboard illumination
> 
>  Current status of KeyBoard Illumination setting on your system: 
> -------------------------------------------------------------------
> 
>  Configured mode state: 
> 	 Auto: Input-activity-based On; input-activity based Off
> 
>  Your Keyboard will illumination on: 
> 	Any Keystroke
> 	Touchpad activity
> 	Pointing stick
> 
>  Keyboard illumination timeout has bee set at: 10  Seconds
> 
>  Current setting of ALS value that turns the light on or off: 18
>  Current ALS Reading : 16
>  Current keyboard light level : 9
> 
> 
> -------- Original Message --------
> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
> E6410
> From: Pali Rohár <pali.rohar@gmail.com>
> Date: Thu, September 14, 2017 3:06 am
> To: "Gabriel M. Elder" <gabriel@tekgnowsys.com>
> Cc: dvhart@infradead.org, andy@infradead.org,
> platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
> 
> On Monday 11 September 2017 23:25:27 Gabriel M. Elder wrote:
> > Hi all,
> > Hans de Goede, one of the upower maintainers, suggested I alert you all to this bug:
> > 
> > https://bugs.freedesktop.org/show_bug.cgi?id=100041
> > 
> > and the new one I filed via the kernel bugzilla:
> > 
> > https://bugzilla.kernel.org/show_bug.cgi?id=196913
> > "keyboard backlight max_brightness value outside allowable range on Dell Latitude E6410 laptop"
> > 
> > Please check it out at your earliest convenience.
> > 
> > thanks,
> > - Gabriel</html>
> 
> Hi Gabriel, please avoid sending such html emails to mailing list as it
> is hard to read them and also you have a very big chance that email
> would be eaten by spam filter or other developers would completely
> ignore it...
> 
> To debug your problem, can you run smbios-keyboard-ctl tool from the
> libsmbios project? https://github.com/dell/libsmbios
> 
> We would need output from --info parameter and also from --get-status.
> 

-- 
Pali Rohár
pali.rohar@gmail.com

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

[Gabriele Mazzotta]

2017-09-14 15:54 GMT+02:00 Pali Rohár <pali.rohar@gmail.com>:
> Adding Gabriele to thread, IIRC you have machine which uses
> "supported keyboard light brightness levels"
> Can you look at this bug, if your machine is affected by it too?

My keyboard has two brightness levels + off. The value of
max_brightness is 2, as expected.

Gabriele

Yes, my laptop uses "supported keyboard light brightness levels".
>
> Important parts in ouptput:
>
>> ... --info
>>  Supported Keyboard light brightness levels :  10
>
>> ... --get-status
>>  Current keyboard light level : 9
>
> Gabriel, can you play with this tool, which values can be set via
> --set-level= parameter? Is 10 accepted? --get-status can be used to
> check if value was accepted.
>
> On Thursday 14 September 2017 06:35:15 Gabriel M. Elder wrote:
>>
>> output from smbios-keyboard-ctl --info:
>>
>> Libsmbios version : 2.3.0
>> smbios-keyboard-ctl version : 2.3.0
>>
>>  Capabilities of KeyBoard Illumination on your system:
>> -------------------------------------------------------------------
>>  Supported USER Selectable Modes :
>>        Always OFF
>>        Auto: ALS- and input-activity-based On; input-activity based Off
>>        Auto: Input-activity-based On; input-activity based Off
>>
>>  Supported Keyboard illumination type :  Backlight
>>
>>  Supports Keyboard illumination on :
>>       Any Keystroke
>>       Touchpad activity
>>       Pointing stick
>>
>>  Can configure Keyboard illumination timeout unit in :
>>       Seconds
>>       Minutes
>>       Hours
>>
>>  Supported Keyboard light brightness levels :  10
>>
>>  Maximum acceptable seconds timeout value   :  255
>>
>>  Maximum acceptable minutes timeout value   :  255
>>
>>  Maximum acceptable hours timeout value     :  12
>>
>>  Maximum acceptable days timeout value      :  0
>>
>>
>> output from smbios-keyboard-ctl --get-status:
>>
>> Helper function to print current status of keyboard illumination
>>
>>  Current status of KeyBoard Illumination setting on your system:
>> -------------------------------------------------------------------
>>
>>  Configured mode state:
>>        Auto: Input-activity-based On; input-activity based Off
>>
>>  Your Keyboard will illumination on:
>>       Any Keystroke
>>       Touchpad activity
>>       Pointing stick
>>
>>  Keyboard illumination timeout has bee set at: 10  Seconds
>>
>>  Current setting of ALS value that turns the light on or off: 18
>>  Current ALS Reading : 16
>>  Current keyboard light level : 9
>>
>>
>> -------- Original Message --------
>> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
>> E6410
>> From: Pali Rohár <pali.rohar@gmail.com>
>> Date: Thu, September 14, 2017 3:06 am
>> To: "Gabriel M. Elder" <gabriel@tekgnowsys.com>
>> Cc: dvhart@infradead.org, andy@infradead.org,
>> platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
>>
>> On Monday 11 September 2017 23:25:27 Gabriel M. Elder wrote:
>> > Hi all,
>> > Hans de Goede, one of the upower maintainers, suggested I alert you all to this bug:
>> >
>> > https://bugs.freedesktop.org/show_bug.cgi?id=100041
>> >
>> > and the new one I filed via the kernel bugzilla:
>> >
>> > https://bugzilla.kernel.org/show_bug.cgi?id=196913
>> > "keyboard backlight max_brightness value outside allowable range on Dell Latitude E6410 laptop"
>> >
>> > Please check it out at your earliest convenience.
>> >
>> > thanks,
>> > - Gabriel</html>
>>
>> Hi Gabriel, please avoid sending such html emails to mailing list as it
>> is hard to read them and also you have a very big chance that email
>> would be eaten by spam filter or other developers would completely
>> ignore it...
>>
>> To debug your problem, can you run smbios-keyboard-ctl tool from the
>> libsmbios project? https://github.com/dell/libsmbios
>>
>> We would need output from --info parameter and also from --get-status.
>>
>
> --
> Pali Rohár
> pali.rohar@gmail.com

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

[Pali Rohár]

On Thursday 14 September 2017 16:33:57 Gabriele Mazzotta wrote:
> 2017-09-14 15:54 GMT+02:00 Pali Rohár <pali.rohar@gmail.com>:
> > Adding Gabriele to thread, IIRC you have machine which uses
> > "supported keyboard light brightness levels"
> > Can you look at this bug, if your machine is affected by it too?
> 
> My keyboard has two brightness levels + off. The value of
> max_brightness is 2, as expected.

Ah :-(

So you have "Supported Keyboard light brightness levels :  2" and you
can se value 0, 1 or 2.

And Gabriel has "Supported Keyboard light brightness levels :  10" and
can set only values 0..9. But not 10.

Any idea how to solve this situation?

CCing Mario from Dell. Can you recheck what is wrong here? Or why
Dell Latitude E6410 behaves differently?

> Gabriele
> 
> Yes, my laptop uses "supported keyboard light brightness levels".
> >
> > Important parts in ouptput:
> >
> >> ... --info
> >>  Supported Keyboard light brightness levels :  10
> >
> >> ... --get-status
> >>  Current keyboard light level : 9
> >
> > Gabriel, can you play with this tool, which values can be set via
> > --set-level= parameter? Is 10 accepted? --get-status can be used to
> > check if value was accepted.
> >
> > On Thursday 14 September 2017 06:35:15 Gabriel M. Elder wrote:
> >>
> >> output from smbios-keyboard-ctl --info:
> >>
> >> Libsmbios version : 2.3.0
> >> smbios-keyboard-ctl version : 2.3.0
> >>
> >>  Capabilities of KeyBoard Illumination on your system:
> >> -------------------------------------------------------------------
> >>  Supported USER Selectable Modes :
> >>        Always OFF
> >>        Auto: ALS- and input-activity-based On; input-activity based Off
> >>        Auto: Input-activity-based On; input-activity based Off
> >>
> >>  Supported Keyboard illumination type :  Backlight
> >>
> >>  Supports Keyboard illumination on :
> >>       Any Keystroke
> >>       Touchpad activity
> >>       Pointing stick
> >>
> >>  Can configure Keyboard illumination timeout unit in :
> >>       Seconds
> >>       Minutes
> >>       Hours
> >>
> >>  Supported Keyboard light brightness levels :  10
> >>
> >>  Maximum acceptable seconds timeout value   :  255
> >>
> >>  Maximum acceptable minutes timeout value   :  255
> >>
> >>  Maximum acceptable hours timeout value     :  12
> >>
> >>  Maximum acceptable days timeout value      :  0
> >>
> >>
> >> output from smbios-keyboard-ctl --get-status:
> >>
> >> Helper function to print current status of keyboard illumination
> >>
> >>  Current status of KeyBoard Illumination setting on your system:
> >> -------------------------------------------------------------------
> >>
> >>  Configured mode state:
> >>        Auto: Input-activity-based On; input-activity based Off
> >>
> >>  Your Keyboard will illumination on:
> >>       Any Keystroke
> >>       Touchpad activity
> >>       Pointing stick
> >>
> >>  Keyboard illumination timeout has bee set at: 10  Seconds
> >>
> >>  Current setting of ALS value that turns the light on or off: 18
> >>  Current ALS Reading : 16
> >>  Current keyboard light level : 9
> >>
> >>
> >> -------- Original Message --------
> >> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
> >> E6410
> >> From: Pali Rohár <pali.rohar@gmail.com>
> >> Date: Thu, September 14, 2017 3:06 am
> >> To: "Gabriel M. Elder" <gabriel@tekgnowsys.com>
> >> Cc: dvhart@infradead.org, andy@infradead.org,
> >> platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
> >>
> >> On Monday 11 September 2017 23:25:27 Gabriel M. Elder wrote:
> >> > Hi all,
> >> > Hans de Goede, one of the upower maintainers, suggested I alert you all to this bug:
> >> >
> >> > https://bugs.freedesktop.org/show_bug.cgi?id=100041
> >> >
> >> > and the new one I filed via the kernel bugzilla:
> >> >
> >> > https://bugzilla.kernel.org/show_bug.cgi?id=196913
> >> > "keyboard backlight max_brightness value outside allowable range on Dell Latitude E6410 laptop"
> >> >
> >> > Please check it out at your earliest convenience.
> >> >
> >> > thanks,
> >> > - Gabriel</html>
> >>
> >> Hi Gabriel, please avoid sending such html emails to mailing list as it
> >> is hard to read them and also you have a very big chance that email
> >> would be eaten by spam filter or other developers would completely
> >> ignore it...
> >>
> >> To debug your problem, can you run smbios-keyboard-ctl tool from the
> >> libsmbios project? https://github.com/dell/libsmbios
> >>
> >> We would need output from --info parameter and also from --get-status.
> >>
> >
> > --
> > Pali Rohár
> > pali.rohar@gmail.com

-- 
Pali Rohár
pali.rohar@gmail.com

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

[Andy Shevchenko]

On Thu, Sep 14, 2017 at 6:25 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Thursday 14 September 2017 16:33:57 Gabriele Mazzotta wrote:
>> 2017-09-14 15:54 GMT+02:00 Pali Rohár <pali.rohar@gmail.com>:
>> > Adding Gabriele to thread, IIRC you have machine which uses
>> > "supported keyboard light brightness levels"
>> > Can you look at this bug, if your machine is affected by it too?
>>
>> My keyboard has two brightness levels + off. The value of
>> max_brightness is 2, as expected.
>
> Ah :-(
>
> So you have "Supported Keyboard light brightness levels :  2" and you
> can se value 0, 1 or 2.
>
> And Gabriel has "Supported Keyboard light brightness levels :  10" and
> can set only values 0..9. But not 10.
>
> Any idea how to solve this situation?
>
> CCing Mario from Dell. Can you recheck what is wrong here? Or why
> Dell Latitude E6410 behaves differently?

To be clear, am I waiting for new version?

In any case I mark it as Changes Requested in my patchwork queue.

Feel free to send a new version.

-- 
With Best Regards,
Andy Shevchenko

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

[Pali Rohár]

On Saturday 14 October 2017 16:50:27 Andy Shevchenko wrote:
> To be clear, am I waiting for new version?
> 
> In any case I mark it as Changes Requested in my patchwork queue.
> 
> Feel free to send a new version.
> 

Hi, I would prepare a new version based on DMI system check.

-- 
Pali Rohár
pali.rohar@gmail.com

RE: keyboard backlight max_brightness bug on Dell Latitude E6410

[Gabriel M. Elder]

-------- Original Message --------
Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
E6410
From: Pali Rohár <pali.rohar@gmail.com>
Date: Mon, October 02, 2017 8:15 am
To: gabriel@tekgnowsys.com
Cc: andy.shevchenko@gmail.com, gabriel@tekgnowsys.com,
gabriele.mzt@gmail.com, dvhart@infradead.org, andy@infradead.org,
platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
Mario.Limonciello@dell.com

On Monday 02 October 2017 13:06:46 Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Pali Rohár [mailto:pali.rohar@gmail.com]
> > Sent: Monday, October 2, 2017 6:53 AM
> > To: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Cc: Gabriel M. Elder <gabriel@tekgnowsys.com>; Gabriele Mazzotta
> > <gabriele.mzt@gmail.com>; Limonciello, Mario <Mario_Limonciello@Dell.com>;
> > Darren Hart <dvhart@infradead.org>; Andy Shevchenko <andy@infradead.org>;
> > platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: keyboard backlight max_brightness bug on Dell Latitude E6410
> > 
> > On Friday 29 September 2017 18:19:59 Andy Shevchenko wrote:
> > > >> FYI, latest update and info relating to
> > > >> https://bugzilla.kernel.org/show_bug.cgi?id=196913
> > >
> > > Quick solution is to apply DMI to that.
> > 
> > It is only the Dell Latitude E6410 affected?
> > 
> > Mario, do you have any information about that API from Dell?
> > 
> > --
> > Pali Rohár
> > pali.rohar@gmail.com
> 
> Pali,
> 
> I believe this particular API shouldn't have changed over generations, so it's 
> likely something that needs to be quirked for that generation. 
> I haven't had a chance to check on this yet in detail though.
> For now could you guys quirk this one and if I find out there was something
> more systemic we can undo the quirk and do something more broad.
> 
> Thanks,

Ok! Gabriel, can you provide us your DMI information about your machine?

They are included in following files:
/sys/class/dmi/id/sys_vendor
/sys/class/dmi/id/product_name

Beware that they may contain whitespace characters and it is important.

-- 
Pali Rohár
pali.rohar@gmail.com

-------------------------------------------------------------------------------
# cat -v /sys/class/dmi/id/sys_vendor
Dell Inc.
# cat -v /sys/class/dmi/id/product_name
Latitude E6410
# cat -v /sys/class/dmi/id/sys_vendor | hexdump
0000000 6544 6c6c 4920 636e 0a2e               
000000a
# cat -v /sys/class/dmi/id/product_name | hexdump
0000000 614c 6974 7574 6564 4520 3436 3031 000a
000000f

Also updated https://bugzilla.kernel.org/show_bug.cgi?id=196913 with
this info

- Gabriel
-------------------------------------------------------------------------------

RE: keyboard backlight max_brightness bug on Dell Latitude E6410

[Gabriel M. Elder]

FYI, latest update and info relating to
https://bugzilla.kernel.org/show_bug.cgi?id=196913


--- a/drivers/platform/x86/dell-laptop.c	
+++ a/drivers/platform/x86/dell-laptop.c	
@@ -1217,7 +1217,7 @@ static int kbd_get_info(struct kbd_info *info)
 static unsigned int kbd_get_max_level(void)
 {
 	if (kbd_info.levels != 0)
-		return kbd_info.levels;
+		return kbd_info.levels - 1;
 	if (kbd_mode_levels_count > 0)
 		return kbd_mode_levels_count - 1;
 	return 0;


Finally had a chance to make this mod, compile and try it out. Based on
my testing, it seems to completely correct the problem.

Upon initially opening the power panel in gnome-control-center, the
keyboard brightness slider is all the way over to the right, where one
would expect it to be, as well as all of the brightness step levels.
Closing the lid, putting it to sleep and waking it back up does not have
the annoying keyboard backlight disabling side-effect that I previously
described.

- Gabriel


-------- Original Message --------
Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
E6410
From: Pali Rohár <pali.rohar@gmail.com>
Date: Thu, September 14, 2017 10:25 am
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>, Mario Limonciello
<Mario_Limonciello@Dell.com>
Cc: "Gabriel M. Elder" <gabriel@tekgnowsys.com>, Darren Hart
<dvhart@infradead.org>, andy@infradead.org,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>, "linux-kernel@vger.kernel.org"
<linux-kernel@vger.kernel.org>

On Thursday 14 September 2017 16:33:57 Gabriele Mazzotta wrote:
> 2017-09-14 15:54 GMT+02:00 Pali Rohár <pali.rohar@gmail.com>:
> > Adding Gabriele to thread, IIRC you have machine which uses
> > "supported keyboard light brightness levels"
> > Can you look at this bug, if your machine is affected by it too?
> 
> My keyboard has two brightness levels + off. The value of
> max_brightness is 2, as expected.

Ah :-(

So you have "Supported Keyboard light brightness levels : 2" and you
can se value 0, 1 or 2.

And Gabriel has "Supported Keyboard light brightness levels : 10" and
can set only values 0..9. But not 10.

Any idea how to solve this situation?

CCing Mario from Dell. Can you recheck what is wrong here? Or why
Dell Latitude E6410 behaves differently?

> Gabriele
> 
> Yes, my laptop uses "supported keyboard light brightness levels".
> >
> > Important parts in ouptput:
> >
> >> ... --info
> >> Supported Keyboard light brightness levels : 10
> >
> >> ... --get-status
> >> Current keyboard light level : 9
> >
> > Gabriel, can you play with this tool, which values can be set via
> > --set-level= parameter? Is 10 accepted? --get-status can be used to
> > check if value was accepted.
> >
> > On Thursday 14 September 2017 06:35:15 Gabriel M. Elder wrote:
> >>
> >> output from smbios-keyboard-ctl --info:
> >>
> >> Libsmbios version : 2.3.0
> >> smbios-keyboard-ctl version : 2.3.0
> >>
> >> Capabilities of KeyBoard Illumination on your system:
> >> -------------------------------------------------------------------
> >> Supported USER Selectable Modes :
> >> Always OFF
> >> Auto: ALS- and input-activity-based On; input-activity based Off
> >> Auto: Input-activity-based On; input-activity based Off
> >>
> >> Supported Keyboard illumination type : Backlight
> >>
> >> Supports Keyboard illumination on :
> >> Any Keystroke
> >> Touchpad activity
> >> Pointing stick
> >>
> >> Can configure Keyboard illumination timeout unit in :
> >> Seconds
> >> Minutes
> >> Hours
> >>
> >> Supported Keyboard light brightness levels : 10
> >>
> >> Maximum acceptable seconds timeout value : 255
> >>
> >> Maximum acceptable minutes timeout value : 255
> >>
> >> Maximum acceptable hours timeout value : 12
> >>
> >> Maximum acceptable days timeout value : 0
> >>
> >>
> >> output from smbios-keyboard-ctl --get-status:
> >>
> >> Helper function to print current status of keyboard illumination
> >>
> >> Current status of KeyBoard Illumination setting on your system:
> >> -------------------------------------------------------------------
> >>
> >> Configured mode state:
> >> Auto: Input-activity-based On; input-activity based Off
> >>
> >> Your Keyboard will illumination on:
> >> Any Keystroke
> >> Touchpad activity
> >> Pointing stick
> >>
> >> Keyboard illumination timeout has bee set at: 10 Seconds
> >>
> >> Current setting of ALS value that turns the light on or off: 18
> >> Current ALS Reading : 16
> >> Current keyboard light level : 9
> >>
> >>
> >> -------- Original Message --------
> >> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
> >> E6410
> >> From: Pali Rohár <pali.rohar@gmail.com>
> >> Date: Thu, September 14, 2017 3:06 am
> >> To: "Gabriel M. Elder" <gabriel@tekgnowsys.com>
> >> Cc: dvhart@infradead.org, andy@infradead.org,
> >> platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
> >>
> >> On Monday 11 September 2017 23:25:27 Gabriel M. Elder wrote:
> >> > Hi all,
> >> > Hans de Goede, one of the upower maintainers, suggested I alert you all to this bug:
> >> >
> >> > https://bugs.freedesktop.org/show_bug.cgi?id=100041
> >> >
> >> > and the new one I filed via the kernel bugzilla:
> >> >
> >> > https://bugzilla.kernel.org/show_bug.cgi?id=196913
> >> > "keyboard backlight max_brightness value outside allowable range on Dell Latitude E6410 laptop"
> >> >
> >> > Please check it out at your earliest convenience.
> >> >
> >> > thanks,
> >> > - Gabriel</html>
> >>
> >> Hi Gabriel, please avoid sending such html emails to mailing list as it
> >> is hard to read them and also you have a very big chance that email
> >> would be eaten by spam filter or other developers would completely
> >> ignore it...
> >>
> >> To debug your problem, can you run smbios-keyboard-ctl tool from the
> >> libsmbios project? https://github.com/dell/libsmbios
> >>
> >> We would need output from --info parameter and also from --get-status.
> >>
> >
> > --
> > Pali Rohár
> > pali.rohar@gmail.com

-- 
Pali Rohár
pali.rohar@gmail.com

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

[Pali Rohár]

Yes, that would fix problem for you and break other machines...

On Friday 29 September 2017 07:08:23 Gabriel M. Elder wrote:
> FYI, latest update and info relating to
> https://bugzilla.kernel.org/show_bug.cgi?id=196913
> 
> 
> --- a/drivers/platform/x86/dell-laptop.c	
> +++ a/drivers/platform/x86/dell-laptop.c	
> @@ -1217,7 +1217,7 @@ static int kbd_get_info(struct kbd_info *info)
>  static unsigned int kbd_get_max_level(void)
>  {
>  	if (kbd_info.levels != 0)
> -		return kbd_info.levels;
> +		return kbd_info.levels - 1;
>  	if (kbd_mode_levels_count > 0)
>  		return kbd_mode_levels_count - 1;
>  	return 0;
> 
> 
> Finally had a chance to make this mod, compile and try it out. Based on
> my testing, it seems to completely correct the problem.
> 
> Upon initially opening the power panel in gnome-control-center, the
> keyboard brightness slider is all the way over to the right, where one
> would expect it to be, as well as all of the brightness step levels.
> Closing the lid, putting it to sleep and waking it back up does not have
> the annoying keyboard backlight disabling side-effect that I previously
> described.
> 
> - Gabriel
> 
> 
> -------- Original Message --------
> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
> E6410
> From: Pali Rohár <pali.rohar@gmail.com>
> Date: Thu, September 14, 2017 10:25 am
> To: Gabriele Mazzotta <gabriele.mzt@gmail.com>, Mario Limonciello
> <Mario_Limonciello@Dell.com>
> Cc: "Gabriel M. Elder" <gabriel@tekgnowsys.com>, Darren Hart
> <dvhart@infradead.org>, andy@infradead.org,
> "platform-driver-x86@vger.kernel.org"
> <platform-driver-x86@vger.kernel.org>, "linux-kernel@vger.kernel.org"
> <linux-kernel@vger.kernel.org>
> 
> On Thursday 14 September 2017 16:33:57 Gabriele Mazzotta wrote:
> > 2017-09-14 15:54 GMT+02:00 Pali Rohár <pali.rohar@gmail.com>:
> > > Adding Gabriele to thread, IIRC you have machine which uses
> > > "supported keyboard light brightness levels"
> > > Can you look at this bug, if your machine is affected by it too?
> > 
> > My keyboard has two brightness levels + off. The value of
> > max_brightness is 2, as expected.
> 
> Ah :-(
> 
> So you have "Supported Keyboard light brightness levels : 2" and you
> can se value 0, 1 or 2.
> 
> And Gabriel has "Supported Keyboard light brightness levels : 10" and
> can set only values 0..9. But not 10.
> 
> Any idea how to solve this situation?
> 
> CCing Mario from Dell. Can you recheck what is wrong here? Or why
> Dell Latitude E6410 behaves differently?
> 
> > Gabriele
> > 
> > Yes, my laptop uses "supported keyboard light brightness levels".
> > >
> > > Important parts in ouptput:
> > >
> > >> ... --info
> > >> Supported Keyboard light brightness levels : 10
> > >
> > >> ... --get-status
> > >> Current keyboard light level : 9
> > >
> > > Gabriel, can you play with this tool, which values can be set via
> > > --set-level= parameter? Is 10 accepted? --get-status can be used to
> > > check if value was accepted.
> > >
> > > On Thursday 14 September 2017 06:35:15 Gabriel M. Elder wrote:
> > >>
> > >> output from smbios-keyboard-ctl --info:
> > >>
> > >> Libsmbios version : 2.3.0
> > >> smbios-keyboard-ctl version : 2.3.0
> > >>
> > >> Capabilities of KeyBoard Illumination on your system:
> > >> -------------------------------------------------------------------
> > >> Supported USER Selectable Modes :
> > >> Always OFF
> > >> Auto: ALS- and input-activity-based On; input-activity based Off
> > >> Auto: Input-activity-based On; input-activity based Off
> > >>
> > >> Supported Keyboard illumination type : Backlight
> > >>
> > >> Supports Keyboard illumination on :
> > >> Any Keystroke
> > >> Touchpad activity
> > >> Pointing stick
> > >>
> > >> Can configure Keyboard illumination timeout unit in :
> > >> Seconds
> > >> Minutes
> > >> Hours
> > >>
> > >> Supported Keyboard light brightness levels : 10
> > >>
> > >> Maximum acceptable seconds timeout value : 255
> > >>
> > >> Maximum acceptable minutes timeout value : 255
> > >>
> > >> Maximum acceptable hours timeout value : 12
> > >>
> > >> Maximum acceptable days timeout value : 0
> > >>
> > >>
> > >> output from smbios-keyboard-ctl --get-status:
> > >>
> > >> Helper function to print current status of keyboard illumination
> > >>
> > >> Current status of KeyBoard Illumination setting on your system:
> > >> -------------------------------------------------------------------
> > >>
> > >> Configured mode state:
> > >> Auto: Input-activity-based On; input-activity based Off
> > >>
> > >> Your Keyboard will illumination on:
> > >> Any Keystroke
> > >> Touchpad activity
> > >> Pointing stick
> > >>
> > >> Keyboard illumination timeout has bee set at: 10 Seconds
> > >>
> > >> Current setting of ALS value that turns the light on or off: 18
> > >> Current ALS Reading : 16
> > >> Current keyboard light level : 9
> > >>
> > >>
> > >> -------- Original Message --------
> > >> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
> > >> E6410
> > >> From: Pali Rohár <pali.rohar@gmail.com>
> > >> Date: Thu, September 14, 2017 3:06 am
> > >> To: "Gabriel M. Elder" <gabriel@tekgnowsys.com>
> > >> Cc: dvhart@infradead.org, andy@infradead.org,
> > >> platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
> > >>
> > >> On Monday 11 September 2017 23:25:27 Gabriel M. Elder wrote:
> > >> > Hi all,
> > >> > Hans de Goede, one of the upower maintainers, suggested I alert you all to this bug:
> > >> >
> > >> > https://bugs.freedesktop.org/show_bug.cgi?id=100041
> > >> >
> > >> > and the new one I filed via the kernel bugzilla:
> > >> >
> > >> > https://bugzilla.kernel.org/show_bug.cgi?id=196913
> > >> > "keyboard backlight max_brightness value outside allowable range on Dell Latitude E6410 laptop"
> > >> >
> > >> > Please check it out at your earliest convenience.
> > >> >
> > >> > thanks,
> > >> > - Gabriel</html>
> > >>
> > >> Hi Gabriel, please avoid sending such html emails to mailing list as it
> > >> is hard to read them and also you have a very big chance that email
> > >> would be eaten by spam filter or other developers would completely
> > >> ignore it...
> > >>
> > >> To debug your problem, can you run smbios-keyboard-ctl tool from the
> > >> libsmbios project? https://github.com/dell/libsmbios
> > >>
> > >> We would need output from --info parameter and also from --get-status.
> > >>
> > >
> > > --
> > > Pali Rohár
> > > pali.rohar@gmail.com
> 

-- 
Pali Rohár
pali.rohar@gmail.com

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

[Andy Shevchenko]

On Fri, Sep 29, 2017 at 5:11 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> Yes, that would fix problem for you and break other machines...

I dunno what happened to you guys to use top-posting...

>> FYI, latest update and info relating to
>> https://bugzilla.kernel.org/show_bug.cgi?id=196913

Quick solution is to apply DMI to that.

-- 
With Best Regards,
Andy Shevchenko

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

[Pali Rohár]

On Friday 29 September 2017 18:19:59 Andy Shevchenko wrote:
> >> FYI, latest update and info relating to
> >> https://bugzilla.kernel.org/show_bug.cgi?id=196913
> 
> Quick solution is to apply DMI to that.

It is only the Dell Latitude E6410 affected?

Mario, do you have any information about that API from Dell?

-- 
Pali Rohár
pali.rohar@gmail.com

RE: keyboard backlight max_brightness bug on Dell Latitude E6410

[Mario.Limonciello]

> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@gmail.com]
> Sent: Monday, October 2, 2017 6:53 AM
> To: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Gabriel M. Elder <gabriel@tekgnowsys.com>; Gabriele Mazzotta
> <gabriele.mzt@gmail.com>; Limonciello, Mario <Mario_Limonciello@Dell.com>;
> Darren Hart <dvhart@infradead.org>; Andy Shevchenko <andy@infradead.org>;
> platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude E6410
> 
> On Friday 29 September 2017 18:19:59 Andy Shevchenko wrote:
> > >> FYI, latest update and info relating to
> > >> https://bugzilla.kernel.org/show_bug.cgi?id=196913
> >
> > Quick solution is to apply DMI to that.
> 
> It is only the Dell Latitude E6410 affected?
> 
> Mario, do you have any information about that API from Dell?
> 
> --
> Pali Rohár
> pali.rohar@gmail.com

Pali,

I believe this particular API shouldn't have changed over generations, so it's 
likely something that needs to be quirked for that generation.  
I haven't had a chance to check on this yet in detail though.
For now could you guys quirk this one and if I find out there was something
more systemic we can undo the quirk and do something more broad.

Thanks,

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

[Pali Rohár]

On Monday 02 October 2017 13:06:46 Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Pali Rohár [mailto:pali.rohar@gmail.com]
> > Sent: Monday, October 2, 2017 6:53 AM
> > To: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Cc: Gabriel M. Elder <gabriel@tekgnowsys.com>; Gabriele Mazzotta
> > <gabriele.mzt@gmail.com>; Limonciello, Mario <Mario_Limonciello@Dell.com>;
> > Darren Hart <dvhart@infradead.org>; Andy Shevchenko <andy@infradead.org>;
> > platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: keyboard backlight max_brightness bug on Dell Latitude E6410
> > 
> > On Friday 29 September 2017 18:19:59 Andy Shevchenko wrote:
> > > >> FYI, latest update and info relating to
> > > >> https://bugzilla.kernel.org/show_bug.cgi?id=196913
> > >
> > > Quick solution is to apply DMI to that.
> > 
> > It is only the Dell Latitude E6410 affected?
> > 
> > Mario, do you have any information about that API from Dell?
> > 
> > --
> > Pali Rohár
> > pali.rohar@gmail.com
> 
> Pali,
> 
> I believe this particular API shouldn't have changed over generations, so it's 
> likely something that needs to be quirked for that generation.  
> I haven't had a chance to check on this yet in detail though.
> For now could you guys quirk this one and if I find out there was something
> more systemic we can undo the quirk and do something more broad.
> 
> Thanks,

Ok! Gabriel, can you provide us your DMI information about your machine?

They are included in following files:
/sys/class/dmi/id/sys_vendor
/sys/class/dmi/id/product_name

Beware that they may contain whitespace characters and it is important.

-- 
Pali Rohár
pali.rohar@gmail.com

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

[Andy Shevchenko]

On Mon, Oct 2, 2017 at 4:15 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Monday 02 October 2017 13:06:46 Mario.Limonciello@dell.com wrote:

> Ok! Gabriel, can you provide us your DMI information about your machine?
>
> They are included in following files:
> /sys/class/dmi/id/sys_vendor
> /sys/class/dmi/id/product_name
>
> Beware that they may contain whitespace characters and it is important.

I would usually suggest to run dmidecode and attach an output somewhere.

(Just my 2 cents :-) )

-- 
With Best Regards,
Andy Shevchenko

RE: keyboard backlight max_brightness bug on Dell Latitude E6410

[Gabriel M. Elder]

I've also been updating
https://bugzilla.kernel.org/show_bug.cgi?id=196913 btw.

What source file is responsible for setting this; led-class.c?

I would like to know, so I can tell it to use the correct value:
max_brightness = supported_brightness_levels-1;  //
!actual_max_brightness+1 :)


# smbios-keyboard-ctl --set-level=10; echo $?

Old Keyboard illumination level is: 9
	  Set Trigger Failed. Failed to write config
	 Error Return Code : cbRES1: 0x-2 cbRES2: 0x93512 cbRES3: 0xCFFFF 
0

# smbios-keyboard-ctl --get-status; echo $?
Helper function to print current status of keyboard illumination

 Current status of KeyBoard Illumination setting on your system: 
-------------------------------------------------------------------

 Configured mode state: 
	 Auto: ALS- and input-activity-based On; input-activity based Off

 Your Keyboard will illumination on: 
	Any Keystroke
	Touchpad activity

 Keyboard illumination timeout has bee set at: 10  Seconds

 Current setting of ALS value that turns the light on or off: 18
 Current ALS Reading : 45
 Current keyboard light level : 9
0


-------- Original Message --------
Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
E6410
From: Pali Rohár <pali.rohar@gmail.com>
Date: Thu, September 14, 2017 8:54 am
To: "Gabriel M. Elder" <gabriel@tekgnowsys.com>, Gabriele Mazzotta
<gabriele.mzt@gmail.com>
Cc: dvhart@infradead.org, andy@infradead.org,
platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org

Adding Gabriele to thread, IIRC you have machine which uses
"supported keyboard light brightness levels"
Can you look at this bug, if your machine is affected by it too?

Important parts in ouptput:

> ... --info
> Supported Keyboard light brightness levels : 10

> ... --get-status
> Current keyboard light level : 9

Gabriel, can you play with this tool, which values can be set via
--set-level= parameter? Is 10 accepted? --get-status can be used to
check if value was accepted.

On Thursday 14 September 2017 06:35:15 Gabriel M. Elder wrote:
> 
> output from smbios-keyboard-ctl --info:
> 
> Libsmbios version : 2.3.0
> smbios-keyboard-ctl version : 2.3.0
> 
> Capabilities of KeyBoard Illumination on your system: 
> -------------------------------------------------------------------
> Supported USER Selectable Modes : 
> Always OFF
> Auto: ALS- and input-activity-based On; input-activity based Off
> Auto: Input-activity-based On; input-activity based Off
> 
> Supported Keyboard illumination type : Backlight
> 
> Supports Keyboard illumination on : 
> Any Keystroke
> Touchpad activity
> Pointing stick
> 
> Can configure Keyboard illumination timeout unit in : 
> Seconds
> Minutes
> Hours
> 
> Supported Keyboard light brightness levels : 10
> 
> Maximum acceptable seconds timeout value : 255
> 
> Maximum acceptable minutes timeout value : 255
> 
> Maximum acceptable hours timeout value : 12
> 
> Maximum acceptable days timeout value : 0
> 
> 
> output from smbios-keyboard-ctl --get-status:
> 
> Helper function to print current status of keyboard illumination
> 
> Current status of KeyBoard Illumination setting on your system: 
> -------------------------------------------------------------------
> 
> Configured mode state: 
> Auto: Input-activity-based On; input-activity based Off
> 
> Your Keyboard will illumination on: 
> Any Keystroke
> Touchpad activity
> Pointing stick
> 
> Keyboard illumination timeout has bee set at: 10 Seconds
> 
> Current setting of ALS value that turns the light on or off: 18
> Current ALS Reading : 16
> Current keyboard light level : 9
> 
> 
> -------- Original Message --------
> Subject: Re: keyboard backlight max_brightness bug on Dell Latitude
> E6410
> From: Pali Rohár <pali.rohar@gmail.com>
> Date: Thu, September 14, 2017 3:06 am
> To: "Gabriel M. Elder" <gabriel@tekgnowsys.com>
> Cc: dvhart@infradead.org, andy@infradead.org,
> platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
> 
> On Monday 11 September 2017 23:25:27 Gabriel M. Elder wrote:
> > Hi all,
> > Hans de Goede, one of the upower maintainers, suggested I alert you all to this bug:
> > 
> > https://bugs.freedesktop.org/show_bug.cgi?id=100041
> > 
> > and the new one I filed via the kernel bugzilla:
> > 
> > https://bugzilla.kernel.org/show_bug.cgi?id=196913
> > "keyboard backlight max_brightness value outside allowable range on Dell Latitude E6410 laptop"
> > 
> > Please check it out at your earliest convenience.
> > 
> > thanks,
> > - Gabriel</html>
> 
> Hi Gabriel, please avoid sending such html emails to mailing list as it
> is hard to read them and also you have a very big chance that email
> would be eaten by spam filter or other developers would completely
> ignore it...
> 
> To debug your problem, can you run smbios-keyboard-ctl tool from the
> libsmbios project? https://github.com/dell/libsmbios
> 
> We would need output from --info parameter and also from --get-status.
> 

-- 
Pali Rohár
pali.rohar@gmail.com

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

[Pali Rohár]

On Monday 11 September 2017 23:25:27 Gabriel M. Elder wrote:
> <html><body><span style="font-family:Verdana; color:#000; font-size:10pt;"><div>Hi all,</div><div><br></div><div>Hans de Goede, one of the upower maintainers, suggested I alert you all to this bug:</div><div><br></div><div><a href="https://bugs.freedesktop.org/show_bug.cgi?id=100041" mce_href="https://bugs.freedesktop.org/show_bug.cgi?id=100041" title="https://bugs.freedesktop.org/show_bug.cgi?id=100041" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=100041</a><br></div><div><br></div><div>and the new one I filed via the kernel bugzilla:</div><div><br></div><div><a href="https://bugzilla.kernel.org/show_bug.cgi?id=196913" mce_href="https://bugzilla.kernel.org/show_bug.cgi?id=196913" title="https://bugzilla.kernel.org/show_bug.cgi?id=196913" target="_blank">https://bugzilla.kernel.org/show_bug.cgi?id=196913</a><br></div><div><br></div><div>"<span id="summary_container"><span id="short_desc_nonedit_display">keyboard backlight max_brightness value outside allowable range on Dell Latitude E6410 laptop"</span></span></div><div><br></div><div>Please check it out at your earliest convenience.</div><div><br></div><div>thanks,</div><div>- Gabriel</div></span></body></html>

Hi Gabriel, please avoid sending such html emails to mailing list as it
is hard to read them and also you have a very big chance that email
would be eaten by spam filter or other developers would completely
ignore it...

To debug your problem, can you run smbios-keyboard-ctl tool from the
libsmbios project? https://github.com/dell/libsmbios

We would need output from --info parameter and also from --get-status.

-- 
Pali Rohár
pali.rohar@gmail.com

keyboard backlight max_brightness bug on Dell Latitude E6410

[Gabriel M. Elder]

Hi all,

Hans de Goede, one of the upower maintainers, suggested I alert you all
to this bug:

https://bugs.freedesktop.org/show_bug.cgi?id=100041

and the new one I filed via the kernel bugzilla:

https://bugzilla.kernel.org/show_bug.cgi?id=196913

"keyboard backlight max_brightness value outside allowable range on Dell
Latitude E6410 laptop"

Please check it out at your earliest convenience.


thanks,
- Gabriel