From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751850AbdINVsh (ORCPT <rfc822;w@1wt.eu>);
        Thu, 14 Sep 2017 17:48:37 -0400
Received: from mail-pf0-f193.google.com ([209.85.192.193]:36218 "EHLO
        mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751711AbdINVsg (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Sep 2017 17:48:36 -0400
X-Google-Smtp-Source: ADKCNb7SuJjks0XfJBE7eSFWnHZQOF8Wjc8J3b4x2GKw7pKQjcpScgBHspcSBSSknXaTYkJOL4oasA==
Date: Thu, 14 Sep 2017 14:49:08 -0700
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] dmaengine: imx-sdma: Correct src_addr_widths and
 directions
Message-ID: <20170914214907.GA29201@Asurada-Nvidia>
References: <1505414803-21226-1-git-send-email-nicoleotsuka@gmail.com>
 <CAOMZO5CA3pw02H=qs1OTnZ3DVoMhnYRuYYmDpYMZYkmnwWAy2Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOMZO5CA3pw02H=qs1OTnZ3DVoMhnYRuYYmDpYMZYkmnwWAy2Q@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 14, 2017 at 04:43:08PM -0300, Fabio Estevam wrote:
> Hi Nicolin,
> 
> On Thu, Sep 14, 2017 at 3:46 PM, Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> > The driver already supports DMA_DEV_TO_DEV in sdma_config(),
> > DMA_SLAVE_BUSWIDTH_2_BYTES and DMA_SLAVE_BUSWIDTH_1_BYTE in
> > sdma_prep_slave_sg(). So this patch adds them to the lists.
> >
> > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> 
> Patch looks good.
> 
> Just curious: what is the specific usecase that triggered this change?

Any audio test case. The ASoC generic dmaengine gets the DMA
cap (4_BYTES only) and apply it to hw->formats in ASoC core.
SSI + WM8962 could have S8_LE, S16_LE and S24_LE formats but
it turns out that it only has S24_LE now because of this.

I haven't seen any side effect by DMA_DEV_TO_DEV yet but it
could potentially break ASRC once a similar constrain based
on the "directions" is applied.