From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751685AbdIOTA1 (ORCPT ); Fri, 15 Sep 2017 15:00:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:51462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbdIOTA0 (ORCPT ); Fri, 15 Sep 2017 15:00:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3236021EAB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 15 Sep 2017 16:00:24 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Andi Kleen , linux-kernel@vger.kernel.org, jolsa@kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools: Improve error messages for missing PMUs Message-ID: <20170915190024.GD14469@kernel.org> References: <20170913215006.32222-1-andi@firstfloor.org> <20170915184510.GB31734@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170915184510.GB31734@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Sep 15, 2017 at 08:45:10PM +0200, Jiri Olsa escreveu: > On Wed, Sep 13, 2017 at 02:50:06PM -0700, Andi Kleen wrote: > > +++ b/tools/perf/util/metricgroup.c > > @@ -477,7 +477,7 @@ int metricgroup__parse_groups(const struct option *opt, > > memset(&parse_error, 0, sizeof(struct parse_events_error)); > > ret = parse_events(perf_evlist, extra_events.buf, &parse_error); > > if (ret) { > > - pr_err("Cannot set up events %s\n", extra_events.buf); > > + parse_events_print_error(&parse_error, extra_events.buf); > > nit, mixed tabs/spaces indent, other than that: Fixed that. > Acked-by: Jiri Olsa Thanks, applied. - Arnaldo