From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbdIOXpR (ORCPT ); Fri, 15 Sep 2017 19:45:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59266 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbdIOXpQ (ORCPT ); Fri, 15 Sep 2017 19:45:16 -0400 Date: Fri, 15 Sep 2017 16:45:14 -0700 From: Greg KH To: Serge Semin Cc: richard.leitner@skidata.com, robh+dt@kernel.org, mark.rutland@arm.com, Sergey.Semin@t-platforms.ru, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support Message-ID: <20170915234514.GA8407@kroah.com> References: <20170915233113.17855-1-fancer.lancer@gmail.com> <20170915233113.17855-2-fancer.lancer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170915233113.17855-2-fancer.lancer@gmail.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 16, 2017 at 02:31:09AM +0300, Serge Semin wrote: > USB2517i hubs are very like USB251xb devices series. They have almost > the same configuration registers space except number of ports, led > configurations and lack of battery settings. All these peculiarities > are reflected in this patch. Please add one type of feature at a time per patch. That makes it easier to review and ensure you got it right. thanks, greg k-h