public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Sheng-Hui J. Chu" <jeffrey.chu@outlook.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"johan@kernel.org" <johan@kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jeffrey Chu <jeffrey.chu@cypress.com>
Subject: Re: [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board
Date: Mon, 18 Sep 2017 10:40:35 +0200	[thread overview]
Message-ID: <20170918084035.GB3198@localhost> (raw)
In-Reply-To: <BLUPR11MB0673DEB7AA176C24DFD599A3ED950@BLUPR11MB0673.namprd11.prod.outlook.com>

On Fri, Sep 08, 2017 at 09:08:58PM +0000, Sheng-Hui J. Chu wrote:
> From: Jeffrey Chu <jeffrey.chu@cypress.com>
> 
> Add CYPRESS_VID vid and CYPRESS_WICED_BT_USB and CYPRESS_WICED_WL_USB
> device IDs to ftdi_sio driver
> 
> Signed-off-by: Jeffrey Chu <jeffrey.chu@cypress.com>

I have two v9 of this patch in my mailbox with different authorship and
sent five minutes apart. I figured you really wanted this last one
applied, but next time make sure to increase the patch revision (e.g.
mark it as v10) to avoid any confusion.

> ---
>  drivers/usb/serial/ftdi_sio.c     | 2 ++
>  drivers/usb/serial/ftdi_sio_ids.h | 7 +++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 1cec037..49d1b2d 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1015,6 +1015,8 @@ static const struct usb_device_id id_table_combined[] = {
>  	{ USB_DEVICE(WICED_VID, WICED_USB20706V2_PID) },
>  	{ USB_DEVICE(TI_VID, TI_CC3200_LAUNCHPAD_PID),
>  		.driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> +	{ USB_DEVICE(CYPRESS_VID, CYPRESS_WICED_BT_USB_PID) },
> +	{ USB_DEVICE(CYPRESS_VID, CYPRESS_WICED_WL_USB_PID) },
>  	{ }					/* Terminating entry */
>  };
>  
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index 4fcf1ce..d58dc1b 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -692,6 +692,13 @@
>  #define WICED_USB20706V2_PID	0x6422
>  
>  /*
> + * Cypress WICED USB UART
> + */
> +#define CYPRESS_VID		0x04B4
> +#define CYPRESS_WICED_BT_USB_PID	0x009B
> +#define CYPRESS_WICED_WL_USB_PID	0xF900
> +
> +/*
>   * Definitions for ID TECH (www.idt-net.com) devices
>   */
>  #define IDTECH_VID		0x0ACD	/* ID TECH Vendor ID */

I've applied this one now with some minor tweaks (e.g. kept the define
sections sorted by VID, and adjusted the commit message slightly).

Thanks,
Johan

       reply	other threads:[~2017-09-18  8:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BLUPR11MB0673DEB7AA176C24DFD599A3ED950@BLUPR11MB0673.namprd11.prod.outlook.com>
2017-09-18  8:40 ` Johan Hovold [this message]
2017-09-18 16:58   ` [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board Jeffrey Chu
2017-09-08 17:47 Jeffrey Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170918084035.GB3198@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeffrey.chu@cypress.com \
    --cc=jeffrey.chu@outlook.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox