From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755692AbdIRJzQ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 18 Sep 2017 05:55:16 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:33594 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751535AbdIRJzO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Sep 2017 05:55:14 -0400
Date: Mon, 18 Sep 2017 11:55:25 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org,
        outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove unused
 variable ret
Message-ID: <20170918095525.GA14946@kroah.com>
References: <1505404910-11548-1-git-send-email-harshasharmaiitr@gmail.com>
 <alpine.DEB.2.20.1709141807561.3185@hadrien>
 <CANMOCy2qhAaEdwLGM3L7sJmFNkNTqeRnwoy4am5yFt6ie5QhOQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANMOCy2qhAaEdwLGM3L7sJmFNkNTqeRnwoy4am5yFt6ie5QhOQ@mail.gmail.com>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 14, 2017 at 10:21:29PM +0530, Harsha Sharma wrote:
> Hi,
> Yes, you are right but the function returns 0 in the end and the changes
> compiles well .

Then the function is incorrect, it should be reporting back that error.

thanks,

greg k-h