From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753408AbdIROCf (ORCPT <rfc822;w@1wt.eu>);
        Mon, 18 Sep 2017 10:02:35 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:57912 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752482AbdIROCe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Sep 2017 10:02:34 -0400
Date: Mon, 18 Sep 2017 16:02:44 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Riley Andrews <riandrews@android.com>, devel@driverdev.osuosl.org,
        Todd Kjos <tkjos@android.com>, linux-kernel@vger.kernel.org,
        John Stultz <john.stultz@linaro.org>,
        Martijn Coenen <maco@android.com>
Subject: Re: [PATCH] android: binder: fix type mismatch warning
Message-ID: <20170918140244.GB21714@kroah.com>
References: <20170905085640.1566593-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170905085640.1566593-1-arnd@arndb.de>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 05, 2017 at 10:56:13AM +0200, Arnd Bergmann wrote:
> Allowing binder to expose the 64-bit API on 32-bit kernels caused a
> build warning:
> 
> drivers/android/binder.c: In function 'binder_transaction_buffer_release':
> drivers/android/binder.c:2220:15: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>     fd_array = (u32 *)(parent_buffer + fda->parent_offset);
>                ^
> drivers/android/binder.c: In function 'binder_translate_fd_array':
> drivers/android/binder.c:2445:13: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>   fd_array = (u32 *)(parent_buffer + fda->parent_offset);
>              ^
> drivers/android/binder.c: In function 'binder_fixup_parent':
> drivers/android/binder.c:2511:18: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> 
> This adds extra type casts to avoid the warning.
> 
> However, there is another problem with the Kconfig option: turning
> it on or off creates two incompatible ABI versions, a kernel that
> has this enabled cannot run user space that was built without it
> or vice versa. A better solution might be to leave the option hidden
> until the binder code is fixed to deal with both ABI versions.

I don't know if that is ever going to be fixed, as it's not an issue
that you will ever see "in the wild" from what I can tell...

thanks,

greg k-h