From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbdIROJZ (ORCPT ); Mon, 18 Sep 2017 10:09:25 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59984 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751661AbdIROJY (ORCPT ); Mon, 18 Sep 2017 10:09:24 -0400 Date: Mon, 18 Sep 2017 16:09:34 +0200 From: Greg Kroah-Hartman To: srinivas.kandagatla@linaro.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada Subject: Re: [PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c Message-ID: <20170918140934.GA2512@kroah.com> References: <20170911090014.16806-1-srinivas.kandagatla@linaro.org> <20170911090014.16806-4-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170911090014.16806-4-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 11, 2017 at 11:00:13AM +0200, srinivas.kandagatla@linaro.org wrote: > From: Masahiro Yamada > > These two functions are defined in .c file, but called just once > (at least for now). So, the compiler will fold them into their > callers even without the "inline" markers. > > However, this kind of optimization should not be done by hand. > It is compiler's judge after all. > > Signed-off-by: Masahiro Yamada > Signed-off-by: Srinivas Kandagatla > --- > drivers/nvmem/core.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) This isn't really a bugfix, so should wait for 4.15-rc1. thanks, greg k-h