From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754216AbdIROWu (ORCPT ); Mon, 18 Sep 2017 10:22:50 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37752 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754162AbdIROWr (ORCPT ); Mon, 18 Sep 2017 10:22:47 -0400 Date: Mon, 18 Sep 2017 16:22:40 +0200 From: Heiko Carstens To: Jean Delvare Cc: linux-s390@vger.kernel.org, LKML , Martin Schwidefsky Subject: Re: [PATCH v2] s390/char: Fix cdev_add usage References: <20170918111313.1fc7126e@endymion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170918111313.1fc7126e@endymion> X-TM-AS-GCONF: 00 x-cbid: 17091814-0040-0000-0000-000003DACC1D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17091814-0041-0000-0000-000025DBF80A Message-Id: <20170918142240.GF4649@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-18_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709180207 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 18, 2017 at 11:13:13AM +0200, Jean Delvare wrote: > Function cdev_add does set cdev->dev, so there is no point in setting > it prior to calling this function. > > Signed-off-by: Jean Delvare > Cc: Martin Schwidefsky > Cc: Heiko Carstens > --- > Untested. Changes since v1 (2016-07-13): > * Improved description > * Added a few blank lines to make the code more readable > > drivers/s390/char/tape_class.c | 3 +-- > drivers/s390/char/vmlogrdr.c | 4 ++-- > drivers/s390/char/vmur.c | 4 ++-- > 3 files changed, 5 insertions(+), 6 deletions(-) Applied, however without the extra blank lines ;) Thanks!