From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753169AbdIRPp2 (ORCPT ); Mon, 18 Sep 2017 11:45:28 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:56530 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbdIRPp0 (ORCPT ); Mon, 18 Sep 2017 11:45:26 -0400 Date: Mon, 18 Sep 2017 08:45:22 -0700 From: Christoph Hellwig To: Huacai Chen Cc: Andrew Morton , Fuxin Zhang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH V5 2/3] mm: dmapool: Align to ARCH_DMA_MINALIGN in non-coherent DMA mode Message-ID: <20170918154522.GA16672@infradead.org> References: <1505708548-4750-1-git-send-email-chenhc@lemote.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505708548-4750-1-git-send-email-chenhc@lemote.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ok, it looks like adding the dma_get_cache_alignment constraint here looks good - but again it should be unconditional.