From: Tejun Heo <tj@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Mark Fasheh <mfasheh@versity.com>,
Joel Becker <jlbec@evilplan.org>,
Andrew Morton <akpm@linux-foundation.org>,
piaojun <piaojun@huawei.com>,
linux-ide@vger.kernel.org, ocfs2-devel@oss.oracle.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: make static arrays const, reduces object code size
Date: Mon, 18 Sep 2017 20:29:56 -0700 [thread overview]
Message-ID: <20170919032956.GP378890@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170918133140.31220-1-colin.king@canonical.com>
On Mon, Sep 18, 2017 at 02:31:40PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrayis on the stack, instead make them static.
> Makes the object code smaller by over 260 bytes:
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
...
> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
> index 74407c6dd592..31a61e8e0152 100644
> --- a/fs/ocfs2/dlm/dlmrecovery.c
> +++ b/fs/ocfs2/dlm/dlmrecovery.c
> @@ -1129,7 +1129,6 @@ static int dlm_send_mig_lockres_msg(struct dlm_ctxt *dlm,
> (mres->num_locks * sizeof(struct dlm_migratable_lock));
>
> /* add an all-done flag if we reached the last lock */
> - orig_flags = mres->flags;
> BUG_ON(total_locks > mres_total_locks);
> if (total_locks == mres_total_locks)
> mres->flags |= DLM_MRES_ALL_DONE;
Looks like patch contamination.
Thanks.
--
tejun
prev parent reply other threads:[~2017-09-19 3:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 13:31 [PATCH] libata: make static arrays const, reduces object code size Colin King
2017-09-19 3:29 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919032956.GP378890@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=jlbec@evilplan.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@versity.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=piaojun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).