From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751463AbdISHRe (ORCPT ); Tue, 19 Sep 2017 03:17:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38718 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbdISHRc (ORCPT ); Tue, 19 Sep 2017 03:17:32 -0400 Date: Tue, 19 Sep 2017 09:17:43 +0200 From: Greg Kroah-Hartman To: Alan Tull Cc: Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel Subject: Re: [PATCH 1/2] fpga: altera-cvp: remove DRIVER_ATTR() usage Message-ID: <20170919071743.GA23085@kroah.com> References: <20170918101736.GA30415@kroah.com> <20170918164225.GA31137@tyrael.ni.corp.natinst.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 18, 2017 at 03:40:13PM -0500, Alan Tull wrote: > On Mon, Sep 18, 2017 at 11:42 AM, Moritz Fischer wrote: > > On Mon, Sep 18, 2017 at 12:17:36PM +0200, Greg Kroah-Hartman wrote: > >> It's better to be explicit and use the DRIVER_ATTR_RW() macro when > >> defining a driver's sysfs file. > >> > >> This is part of a series to drop DRIVER_ATTR() from the tree entirely. > >> > >> Cc: Alan Tull > >> Cc: Moritz Fischer > >> Cc: linux-fpga@vger.kernel.org > >> Signed-off-by: Greg Kroah-Hartman > > Acked-by: Moritz Fischer > Acked-by: Alan Tull Thanks to both of you for the review. greg k-h