Re: [PATCH v3 01/13] perf report: remove code to handle inline frames from browsers

Milian Wolff
2017-09-18T12:43:32Z

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

On Monday, September 18, 2017 1:56:19 PM CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:49PM +0200, Milian Wolff wrote:
> > The follow-up commits will make inline frames first-class citizens
> > in the callchain, thereby obsoleting all of this special code.
>
> so you're removing all the inline callchain implementation
> in this patch and adding it back in following patches?
>
> any chance you could change it gradualy? it's hard to track
> in review if you added everything that you removed ;-)

As I said before, this approach is completely different from the previous one.
There is no way to change it more gradually than what I have done. At least, I
cannot think of one.

Bye

--
Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3826 bytes --]