* [PATCH net-next] net: Remove useless function skb_header_release
@ 2017-09-19 14:32 gfree.wind
2017-09-20 21:30 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: gfree.wind @ 2017-09-19 14:32 UTC (permalink / raw)
To: davem, linux-kernel; +Cc: Gao Feng
From: Gao Feng <gfree.wind@vip.163.com>
There is no one which would invokes the function skb_header_release.
So just remove it now.
Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
---
include/linux/skbuff.h | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 72299ef..ce632cd 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1457,22 +1457,6 @@ static inline int skb_header_unclone(struct sk_buff *skb, gfp_t pri)
}
/**
- * skb_header_release - release reference to header
- * @skb: buffer to operate on
- *
- * Drop a reference to the header part of the buffer. This is done
- * by acquiring a payload reference. You must not read from the header
- * part of skb->data after this.
- * Note : Check if you can use __skb_header_release() instead.
- */
-static inline void skb_header_release(struct sk_buff *skb)
-{
- BUG_ON(skb->nohdr);
- skb->nohdr = 1;
- atomic_add(1 << SKB_DATAREF_SHIFT, &skb_shinfo(skb)->dataref);
-}
-
-/**
* __skb_header_release - release reference to header
* @skb: buffer to operate on
*
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: Remove useless function skb_header_release
2017-09-19 14:32 [PATCH net-next] net: Remove useless function skb_header_release gfree.wind
@ 2017-09-20 21:30 ` David Miller
2017-09-21 4:37 ` Gao Feng
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2017-09-20 21:30 UTC (permalink / raw)
To: gfree.wind; +Cc: linux-kernel
From: gfree.wind@vip.163.com
Date: Tue, 19 Sep 2017 22:32:48 +0800
> From: Gao Feng <gfree.wind@vip.163.com>
>
> There is no one which would invokes the function skb_header_release.
> So just remove it now.
>
> Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
Networking patches must be at least CC:'d to netdev@vger.kernel.org,
thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re:Re: [PATCH net-next] net: Remove useless function skb_header_release
2017-09-20 21:30 ` David Miller
@ 2017-09-21 4:37 ` Gao Feng
0 siblings, 0 replies; 3+ messages in thread
From: Gao Feng @ 2017-09-21 4:37 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel
At 2017-09-21 05:30:46, "David Miller" <davem@davemloft.net> wrote:
>From: gfree.wind@vip.163.com
>Date: Tue, 19 Sep 2017 22:32:48 +0800
>
>> From: Gao Feng <gfree.wind@vip.163.com>
>>
>> There is no one which would invokes the function skb_header_release.
>> So just remove it now.
>>
>> Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
>
>Networking patches must be at least CC:'d to netdev@vger.kernel.org,
>thank you.
Thanks your reminder.
I just used the result of get_maintainer.pl, and didn't noticed this point you mentioned.
I would send it again.
Regards
Feng
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-21 4:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-19 14:32 [PATCH net-next] net: Remove useless function skb_header_release gfree.wind
2017-09-20 21:30 ` David Miller
2017-09-21 4:37 ` Gao Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).