From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038AbdITQbX (ORCPT ); Wed, 20 Sep 2017 12:31:23 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:37698 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846AbdITQbV (ORCPT ); Wed, 20 Sep 2017 12:31:21 -0400 X-Google-Smtp-Source: AOwi7QDaNLekSvdKEEVAVYJ7/8fCvUt0X4oAHScYLCJyXZdZjl/yVTrq7Ve2cDxwJF3FALvQ2F99oQ== Date: Thu, 21 Sep 2017 01:31:17 +0900 From: Sergey Senozhatsky To: Helge Deller , David Laight Cc: "'Sergey Senozhatsky'" , Fenghua Yu , "Luck, Tony" , "linux-ia64@vger.kernel.org" , Petr Mladek , Jessica Yu , "James E . J . Bottomley" , Steven Rostedt , Alexei Starovoitov , Sergey Senozhatsky , Paul Mackerras , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers Message-ID: <20170920163117.GA502@tigerII.localdomain> References: <20170916035347.19705-1-sergey.senozhatsky@gmail.com> <20170918174432.4fksyzco2g6gczwe@intel.com> <20170918183902.GA30752@p100.box> <20170919020537.GA16991@jagdpanzerIV.localdomain> <063D6719AE5E284EB5DD2968C1650D6DD007A0D0@AcuExch.aculab.com> <063D6719AE5E284EB5DD2968C1650D6DD007AF31@AcuExch.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (09/20/17 12:20), Helge Deller wrote: [..] > > I've not looked at the specifics case... > > > > Another option is using a struct with a single member and > > passing it by value. > > Actually, we do already have correct structs which could be referenced: > parisc: struct Elf64_Fdesc > ia64: struct fdesc > ppc64: struct ppc64_opd_entry > > One could "#define platform_opd_entry" to each of those depending on the platform and use it. > It might be misleading though, because the pointer which is handed over to > dereference_function_descriptor() can be such a pointer but isn't necessary. > I'll leave it up to Sergey to decide. Hello, I think I'll keep 'unsigned long' for now. -ss