From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] init/version: include <linux/export.h> instead of <linux/module.h>
Date: Wed, 20 Sep 2017 16:55:19 -0400 [thread overview]
Message-ID: <20170920205519.GM3007@windriver.com> (raw)
In-Reply-To: <1505920984-8523-1-git-send-email-yamada.masahiro@socionext.com>
[[PATCH] init/version: include <linux/export.h> instead of <linux/module.h>] On 21/09/2017 (Thu 00:23) Masahiro Yamada wrote:
> init/version.c has nothing to do with module, so remove
> the <linux/modude.h>.
>
> Instead, include <linux/export.h> for EXPORT_SYMBOL_GPL.
I checked and there weren't any __init lurking in that file which is the
usual other required replacement (<linux/init.h>) so this should be
fine.
Paul.
--
>
> This cuts off a lot of unnecessary header parsing.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> init/version.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/version.c b/init/version.c
> index 5606341..bfb4e3f 100644
> --- a/init/version.c
> +++ b/init/version.c
> @@ -7,7 +7,7 @@
> */
>
> #include <generated/compile.h>
> -#include <linux/module.h>
> +#include <linux/export.h>
> #include <linux/uts.h>
> #include <linux/utsname.h>
> #include <generated/utsrelease.h>
> --
> 2.7.4
>
prev parent reply other threads:[~2017-09-20 20:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 15:23 [PATCH] init/version: include <linux/export.h> instead of <linux/module.h> Masahiro Yamada
2017-09-20 20:55 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920205519.GM3007@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).