* [PATCH] init/version: include <linux/export.h> instead of <linux/module.h>
@ 2017-09-20 15:23 Masahiro Yamada
2017-09-20 20:55 ` Paul Gortmaker
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2017-09-20 15:23 UTC (permalink / raw)
To: Andrew Morton
Cc: Paul Gortmaker, Masahiro Yamada, Ingo Molnar, Peter Zijlstra,
linux-kernel
init/version.c has nothing to do with module, so remove
the <linux/modude.h>.
Instead, include <linux/export.h> for EXPORT_SYMBOL_GPL.
This cuts off a lot of unnecessary header parsing.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
init/version.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/version.c b/init/version.c
index 5606341..bfb4e3f 100644
--- a/init/version.c
+++ b/init/version.c
@@ -7,7 +7,7 @@
*/
#include <generated/compile.h>
-#include <linux/module.h>
+#include <linux/export.h>
#include <linux/uts.h>
#include <linux/utsname.h>
#include <generated/utsrelease.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] init/version: include <linux/export.h> instead of <linux/module.h>
2017-09-20 15:23 [PATCH] init/version: include <linux/export.h> instead of <linux/module.h> Masahiro Yamada
@ 2017-09-20 20:55 ` Paul Gortmaker
0 siblings, 0 replies; 2+ messages in thread
From: Paul Gortmaker @ 2017-09-20 20:55 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Andrew Morton, Ingo Molnar, Peter Zijlstra, linux-kernel
[[PATCH] init/version: include <linux/export.h> instead of <linux/module.h>] On 21/09/2017 (Thu 00:23) Masahiro Yamada wrote:
> init/version.c has nothing to do with module, so remove
> the <linux/modude.h>.
>
> Instead, include <linux/export.h> for EXPORT_SYMBOL_GPL.
I checked and there weren't any __init lurking in that file which is the
usual other required replacement (<linux/init.h>) so this should be
fine.
Paul.
--
>
> This cuts off a lot of unnecessary header parsing.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> init/version.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/version.c b/init/version.c
> index 5606341..bfb4e3f 100644
> --- a/init/version.c
> +++ b/init/version.c
> @@ -7,7 +7,7 @@
> */
>
> #include <generated/compile.h>
> -#include <linux/module.h>
> +#include <linux/export.h>
> #include <linux/uts.h>
> #include <linux/utsname.h>
> #include <generated/utsrelease.h>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-20 20:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 15:23 [PATCH] init/version: include <linux/export.h> instead of <linux/module.h> Masahiro Yamada
2017-09-20 20:55 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).