public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org,
	"Luis R. Rodriguez" <mcgrof@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Worker threads in D state since c5a94a618e7ac86 (workqueue: Use TASK_IDLE)
Date: Thu, 21 Sep 2017 13:08:42 +0200	[thread overview]
Message-ID: <20170921110842.GA4020@x4> (raw)
In-Reply-To: <20170911142133.GA2265@x4>

On 2017.09.11 at 16:21 +0200, Markus Trippelsdorf wrote:
> On 2017.09.11 at 06:11 -0700, Tejun Heo wrote:
> > Hello,
> >
> > On Sun, Sep 10, 2017 at 09:36:53AM +0200, Markus Trippelsdorf wrote:
> > > Since:
> > >
> > >  commit c5a94a618e7ac86b20f53d947f68d7cee6a4c6bc
> > >  Author: Peter Zijlstra <peterz@infradead.org>
> > >  Date:   Wed Aug 23 13:58:44 2017 +0200
> > >
> > >      workqueue: Use TASK_IDLE
> > >
> > >
> > > all worker threads are in D state. They all show up when using "magic
> > > SysRq w". In htop they all have big fat red 'D' in the state column.
> > > Is this really desirable?
> > >
> > > I have attached the output of "ps aux" after boot and the SysRq-w
> > > output.
> >
> > Hmm.... looks like we better revert until we figure out how this
> > should get presented in debugging facilities / to userspace.  Peter?
> 
> BTW rcu recently introduced the same issue:
> 
>  commit d5374226c3e444239e063f005dfb59cae4390db4
>  Author: Luis R. Rodriguez <mcgrof@kernel.org>
>  Date:   Tue Jun 20 14:45:47 2017 -0700
> 
>      rcu: Use idle versions of swait to make idle-hack clear

Ping? 
You may call it a cosmetic issue, but still it makes debugging much
harder. Finding "real" blocked tasks is now like finding a needle in a
haystack.

-- 
Markus

  reply	other threads:[~2017-09-21 11:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-10  7:36 Worker threads in D state since c5a94a618e7ac86 (workqueue: Use TASK_IDLE) Markus Trippelsdorf
2017-09-11 13:11 ` Tejun Heo
2017-09-11 14:21   ` Markus Trippelsdorf
2017-09-21 11:08     ` Markus Trippelsdorf [this message]
2017-09-21 12:30       ` Peter Zijlstra
2017-09-21 14:41         ` Markus Trippelsdorf
2017-09-22  9:35           ` Markus Trippelsdorf
2017-09-22 11:54             ` [RFC][PATCH] sched: Cleanup task->state printing Peter Zijlstra
2017-09-22 12:40               ` Markus Trippelsdorf
2017-09-22 14:12               ` Steven Rostedt
2017-09-22 15:56                 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170921110842.GA4020@x4 \
    --to=markus@trippelsdorf.de \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox