From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: thierry.reding@gmail.com, airlied@linux.ie, jonathanh@nvidia.com,
daniel.vetter@intel.com, jani.nikula@linux.intel.com,
seanpaul@chromium.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm: Release memory obtained by kasprintf
Date: Thu, 21 Sep 2017 14:24:43 +0300 [thread overview]
Message-ID: <20170921112443.GH4914@intel.com> (raw)
In-Reply-To: <1505892308-6843-3-git-send-email-arvind.yadav.cs@gmail.com>
On Wed, Sep 20, 2017 at 12:55:08PM +0530, Arvind Yadav wrote:
> Free memory region, if drm_crtc_init_with_planes is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/gpu/drm/drm_crtc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 5af25ce..cd4e628 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -328,6 +328,7 @@ int drm_crtc_init_with_planes(struct drm_device *dev, struct drm_crtc *crtc,
> ret = drm_crtc_crc_init(crtc);
> if (ret) {
> drm_mode_object_unregister(dev, &crtc->base);
> + kfree(crtc->name);
Looks correct. However my ocd would wish the kfree() to precede
drm_mode_object_unregister() to make the unwinding mirror the
allocation/registration sequence.
> return ret;
> }
>
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
prev parent reply other threads:[~2017-09-21 11:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 7:25 [PATCH 0/2] Handle / Release memory obtained by kasprintf Arvind Yadav
2017-09-20 7:25 ` [PATCH 1/2] drm: tegra: dc: Handle return value of kasprintf Arvind Yadav
2017-09-21 11:22 ` Ville Syrjälä
2017-09-20 7:25 ` [PATCH 2/2] drm: Release memory obtained by kasprintf Arvind Yadav
2017-09-21 11:24 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921112443.GH4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=arvind.yadav.cs@gmail.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox