From: Al Viro <viro@ZenIV.linux.org.uk>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debugfs: Add check for module parameter name
Date: Thu, 21 Sep 2017 13:44:38 +0100 [thread overview]
Message-ID: <20170921124438.GH32076@ZenIV.linux.org.uk> (raw)
In-Reply-To: <8cf113648f45ccbf304735fcc4487adecd5b7082.1505996056.git.arvind.yadav.cs@gmail.com>
On Thu, Sep 21, 2017 at 05:46:54PM +0530, Arvind Yadav wrote:
> Here, start_creating() is calling by debugfs_create_dir()
> and debugfs_create_automount(). driver can pass name as NULL in
> debugfs_create_dir and debugfs_create_automount. So we need to
> add check for 'name'.
Huh? "Driver can pass any kind of crap pointer when calling this
function, so let's check if that crap happens to be NULL and bail
out in that particular case"? Or am I misreading that?
Do you have any in-tree examples, or is that about some out-of-tree
code that needs to be saved from itself?
next prev parent reply other threads:[~2017-09-21 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 12:16 [PATCH] debugfs: Add check for module parameter name Arvind Yadav
2017-09-21 12:44 ` Al Viro [this message]
2017-09-21 16:47 ` arvind
2017-09-21 17:09 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921124438.GH32076@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arvind.yadav.cs@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).