From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbdIUPVO (ORCPT ); Thu, 21 Sep 2017 11:21:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37754 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbdIUPVN (ORCPT ); Thu, 21 Sep 2017 11:21:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1266F5F7BD Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Thu, 21 Sep 2017 17:21:10 +0200 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 1/6] perf record: Record the first sample time and last sample time to perf file header Message-ID: <20170921152110.GC6579@krava> References: <1505920357-25561-1-git-send-email-yao.jin@linux.intel.com> <1505920357-25561-2-git-send-email-yao.jin@linux.intel.com> <20170921151842.GB6579@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170921151842.GB6579@krava> User-Agent: Mutt/1.9.0 (2017-09-02) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 21 Sep 2017 15:21:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 21, 2017 at 05:18:42PM +0200, Jiri Olsa wrote: > On Wed, Sep 20, 2017 at 11:12:32PM +0800, Jin Yao wrote: > > SNIP > > > @@ -2647,11 +2681,22 @@ int perf_file_header__read(struct perf_file_header *header, > > > > if (header->size != sizeof(*header)) { > > /* Support the previous format */ > > - if (header->size == offsetof(typeof(*header), adds_features)) > > + if (header->size == offsetof(typeof(*header), adds_features)) { > > bitmap_zero(header->adds_features, HEADER_FEAT_BITS); > > - else > > + header->first_sample_time = 0; > > + header->last_sample_time = 0; > > + format_feature = false; > > + format_time = false; > > + } else if (header->size == offsetof(typeof(*header), > > + first_sample_time)) { > > + header->first_sample_time = 0; > > + header->last_sample_time = 0; > > + format_time = false; > > + } else > > ok, disregard my previou comment.. I should have read the full patch first ;-) still using the feature looks better to me.. I think we could add some generic TLV data feature for cases like this jirka