From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751819AbdIUOq5 (ORCPT ); Thu, 21 Sep 2017 10:46:57 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:6538 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbdIUOqy (ORCPT ); Thu, 21 Sep 2017 10:46:54 -0400 Date: Thu, 21 Sep 2017 15:46:21 +0100 From: Jonathan Cameron To: Icenowy Zheng CC: Chen-Yu Tsai , Maxime Ripard , Jonathan Cameron , "Lee Jones" , Quentin Schulz , , , , , , Subject: Re: [RFC PATCH 0/7] AXP803 AC/Battery support Message-ID: <20170921154621.0000328d@huawei.com> In-Reply-To: <20170920151814.22461-1-icenowy@aosc.io> References: <20170920151814.22461-1-icenowy@aosc.io> Organization: Huawei X-Mailer: Claws Mail 3.15.0 (GTK+ 2.24.31; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.206.48.115] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.59C3D0D3.0058,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 45ae5d313cc1ccfada3cb2743d239cd3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Sep 2017 23:18:07 +0800 Icenowy Zheng wrote: > The AXP803 PMIC, used by most Allwinner A64 boards, features 3 power inputs: > AC, USB and Battery. > > This patchset adds support for the AC and Battery supplies, which is useful > for the boards from Pine64 (Pine64, SoPine w/ baseboard model A, Pinebook). > > The USB supply is not yet supported in this patchset because it's not > present on Pine series boards. > > In order to enable battery monitoring the ADC for battery is also enabled > for AXs. > > In order to enable battery monitoring the ADC for battery is also enabled > for AXP803. I'll go with the obvious question... Why an RFC rather than a standard patch submission? I'm not immediately seeing what is controversial! Jonathan > > Icenowy Zheng (7): > dt-bindings: add compatibles for AXP803 Battery/USB power supplies > iio: adc: axp20x-adc: allow to skip ADC rate setup now > iio: adc: axp20x-adc: add support for AXP803 > power: supply: axp20x-battery: support AXP803 > mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery > arm64: allwinner: a64: add power supply nodes in AXP803 DTSI > arm64: allwinner: a64: enable AC and Battery for Pine64 > > .../bindings/power/supply/axp20x_battery.txt | 1 + > .../bindings/power/supply/axp20x_usb_power.txt | 1 + > arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++ > .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 8 ++ > drivers/iio/adc/axp20x_adc.c | 114 ++++++++++++++++++++- > drivers/mfd/axp20x.c | 11 ++ > drivers/power/supply/axp20x_battery.c | 88 ++++++++++++++-- > 7 files changed, 226 insertions(+), 12 deletions(-) >