From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751868AbdIURxN (ORCPT ); Thu, 21 Sep 2017 13:53:13 -0400 Received: from mail-pg0-f52.google.com ([74.125.83.52]:45988 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbdIURxM (ORCPT ); Thu, 21 Sep 2017 13:53:12 -0400 X-Google-Smtp-Source: AOwi7QC98ajgmrykjbncepwi15OffRngDT+YpOq4Q9Myz1Jx+CBg+347B8DVVzOWGXKM3hVxSco7hA== Date: Thu, 21 Sep 2017 10:53:09 -0700 From: Viresh Kumar To: sunil.m@techveda.org Cc: d-gerlach@ti.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, karthik@techveda.org Subject: Re: [PATCH v3] drivers: cpufreq: Fix sysfs duplicate filename creation for platform-device Message-ID: <20170921175309.GC17243@ubuntu> References: <20170919223645.GD30848@ubuntu> <1506001143-20175-1-git-send-email-sunil.m@techveda.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506001143-20175-1-git-send-email-sunil.m@techveda.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-09-17, 19:09, sunil.m@techveda.org wrote: > From: Suniel Mahesh > > ti-cpufreq and cpufreq-dt-platdev drivers are registering platform-device > with same name "cpufreq-dt" using platform_device_register_*() routines. > This is leading to build warnings appended below. > > Providing hardware information to OPP framework along with the platform- > device creation should be done by ti-cpufreq driver before cpufreq-dt > driver comes into place. > > This patch add's TI am33xx, am43 and dra7 platforms (which use opp-v2 > property) to the blacklist of devices in cpufreq-dt-platform driver to > avoid creating platform-device twice and remove build warnings. > > [ 2.370167] ------------[ cut here ]------------ > [ 2.375087] WARNING: CPU: 0 PID: 1 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x58/0x78 > [ 2.383112] sysfs: cannot create duplicate filename '/devices/platform/cpufreq-dt' > [ 2.391219] Modules linked in: > [ 2.394506] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.13.0-next-20170912 #1 > [ 2.402006] Hardware name: Generic AM33XX (Flattened Device Tree) > [ 2.408437] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [ 2.416568] [] (show_stack) from [] (dump_stack+0xac/0xe0) > [ 2.424165] [] (dump_stack) from [] (__warn+0xd8/0x104) > [ 2.431488] [] (__warn) from [] (warn_slowpath_fmt+0x34/0x44) > [ 2.439351] [] (warn_slowpath_fmt) from [] (sysfs_warn_dup+0x58/0x78) > [ 2.447938] [] (sysfs_warn_dup) from [] (sysfs_create_dir_ns+0x80/0x98) > [ 2.456719] [] (sysfs_create_dir_ns) from [] (kobject_add_internal+0x9c/0x2d4) > [ 2.466124] [] (kobject_add_internal) from [] (kobject_add+0x4c/0x9c) > [ 2.474712] [] (kobject_add) from [] (device_add+0xcc/0x57c) > [ 2.482489] [] (device_add) from [] (platform_device_add+0x100/0x220) > [ 2.491085] [] (platform_device_add) from [] (platform_device_register_full+0xf4/0x118) > [ 2.501305] [] (platform_device_register_full) from [] (ti_cpufreq_init+0x150/0x22c) > [ 2.511253] [] (ti_cpufreq_init) from [] (do_one_initcall+0x3c/0x170) > [ 2.519838] [] (do_one_initcall) from [] (kernel_init_freeable+0x1fc/0x2c4) > [ 2.528974] [] (kernel_init_freeable) from [] (kernel_init+0x8/0x110) > [ 2.537565] [] (kernel_init) from [] (ret_from_fork+0x14/0x3c) > [ 2.545981] ---[ end trace 2fc00e213c13ab20 ]--- > [ 2.551051] ------------[ cut here ]------------ > [ 2.555931] WARNING: CPU: 0 PID: 1 at lib/kobject.c:240 kobject_add_internal+0x254/0x2d4 > [ 2.564578] kobject_add_internal failed for cpufreq-dt with -EEXIST, don't try to register > things with the same name in the same directory. > [ 2.577977] Modules linked in: > [ 2.581261] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 4.13.0-next-20170912 #1 > [ 2.590013] Hardware name: Generic AM33XX (Flattened Device Tree) > [ 2.596437] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [ 2.604573] [] (show_stack) from [] (dump_stack+0xac/0xe0) > [ 2.612172] [] (dump_stack) from [] (__warn+0xd8/0x104) > [ 2.619494] [] (__warn) from [] (warn_slowpath_fmt+0x34/0x44) > [ 2.627362] [] (warn_slowpath_fmt) from [] (kobject_add_internal+0x254/0x2d4) > [ 2.636666] [] (kobject_add_internal) from [] (kobject_add+0x4c/0x9c) > [ 2.645255] [] (kobject_add) from [] (device_add+0xcc/0x57c) > [ 2.653027] [] (device_add) from [] (platform_device_add+0x100/0x220) > [ 2.661615] [] (platform_device_add) from [] (platform_device_register_full+0xf4/0x118) > [ 2.671833] [] (platform_device_register_full) from [] (ti_cpufreq_init+0x150/0x22c) > [ 2.681779] [] (ti_cpufreq_init) from [] (do_one_initcall+0x3c/0x170) > [ 2.690377] [] (do_one_initcall) from [] (kernel_init_freeable+0x1fc/0x2c4) > [ 2.699510] [] (kernel_init_freeable) from [] (kernel_init+0x8/0x110) > [ 2.708106] [] (kernel_init) from [] (ret_from_fork+0x14/0x3c) > [ 2.716217] ---[ end trace 2fc00e213c13ab21 ]--- > > Fixes: edeec420de24 ("cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2") > Signed-off-by: Suniel Mahesh > --- > Changes for v3: > - Added ti,am43 and ti,dra7 platforms to the blacklist as requested > by Dave Gerlach. > - Patch Description modified a bit. > - Patch was rebased on pm/linux-next as suggested by Viresh, compile > tested and built(ARCH=arm) on both linux/pm-next and next-20170918. > --- > Changes for v2: > - The approach (as a result patch decsription) was changed as per > inputs given by Viresh. > - Patch was compile tested and built(ARCH=arm) on next-20170918. > --- > Note: > - Patch was hardware tested on AM335x SOC based board. > - cpufreq-dt driver got probed and entries related to Dynamic Voltage > and Frequency scaling were created in > sysfs @ sys/devices/system/cpu/cpu0/cpufreq. > - No build/run-time issues reported. > --- > drivers/cpufreq/cpufreq-dt-platdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c > index 430edad..a753c50 100644 > --- a/drivers/cpufreq/cpufreq-dt-platdev.c > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c > @@ -118,6 +118,10 @@ > > { .compatible = "sigma,tango4", }, > > + { .compatible = "ti,am33xx", }, > + { .compatible = "ti,am43", }, > + { .compatible = "ti,dra7", }, > + > { } > }; Acked-by: Viresh Kumar -- viresh