public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Chunyan Zhang <zhang.chunyan@linaro.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [GIT PULL 1/3] stm class: Fix a use-after-free
Date: Fri, 22 Sep 2017 10:28:57 +0200	[thread overview]
Message-ID: <20170922082857.GA26322@kroah.com> (raw)
In-Reply-To: <20170919154742.19696-2-alexander.shishkin@linux.intel.com>

On Tue, Sep 19, 2017 at 06:47:40PM +0300, Alexander Shishkin wrote:
> For reasons unknown, the stm_source removal path uses device_destroy()
> to kill the underlying device object. Because device_destroy() uses
> devt to look for the device to destroy and the fact that stm_source
> devices don't have one (or all have the same one), it just picks the
> first device in the class, which may well be the wrong one.
> 
> That is, loading stm_console and stm_heartbeat and then removing both
> will die in dereferencing a freed object.
> 
> Since this should have been device_unregister() in the first place,
> use it instead of device_destroy().
> 
> Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Fixes: 7bd1d4093c2 ("stm class: Introduce an abstraction for System Trace Module devices")
> Cc: stable@vger.kernel.org
> ---
>  drivers/hwtracing/stm/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ugh, I just applied these as patches, and didn't do the git pull, sorry
about that, my fault.

But really, patches for short series are really easy for me to do...

thanks,

greg k-h

  reply	other threads:[~2017-09-22  8:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 15:47 [GIT PULL 0/3] intel_th/stm class: Fixes for v4.14 Alexander Shishkin
2017-09-19 15:47 ` [GIT PULL 1/3] stm class: Fix a use-after-free Alexander Shishkin
2017-09-22  8:28   ` Greg KH [this message]
2017-09-22  9:06     ` Alexander Shishkin
2017-09-19 15:47 ` [GIT PULL 2/3] intel_th: pci: Add Cedar Fork PCH support Alexander Shishkin
2017-09-19 15:47 ` [GIT PULL 3/3] intel_th: pci: Add Lewisburg " Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170922082857.GA26322@kroah.com \
    --to=greg@kroah.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=stable@vger.kernel.org \
    --cc=zhang.chunyan@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox