From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752107AbdIVKKD (ORCPT ); Fri, 22 Sep 2017 06:10:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:27925 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbdIVKKC (ORCPT ); Fri, 22 Sep 2017 06:10:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,427,1500966000"; d="scan'208";a="154292654" Date: Fri, 22 Sep 2017 15:43:52 +0530 From: Vinod Koul To: Colin King Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Ramesh Babu , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index Message-ID: <20170922101352.GT30097@localhost> References: <20170920130125.12984-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170920130125.12984-1-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 20, 2017 at 02:01:25PM +0100, Colin King wrote: > From: Colin Ian King > > The call to slk_tplg_fill_res_tkn is passing dir and pin_index in the > wrong order, they need to be in pin_index, dir order to match the function > slk_tplg_fill_res_tkn correctly. > > Detected by CoveritScan, CID#1454992 ("Arguments in wrong order") thanks for this. Acked-By: Vinod Koul Tested-by: Subhransu S. Prusty -- ~Vinod