* [PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index
@ 2017-09-20 13:01 Colin King
2017-09-22 10:13 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-09-20 13:01 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Vinod Koul, Ramesh Babu, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The call to slk_tplg_fill_res_tkn is passing dir and pin_index in the
wrong order, they need to be in pin_index, dir order to match the function
slk_tplg_fill_res_tkn correctly.
Detected by CoveritScan, CID#1454992 ("Arguments in wrong order")
Fixes: f6fa56e22559 ("ASoC: Intel: Skylake: Parse and update module config structure")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/soc/intel/skylake/skl-topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index 22f768ca3c73..27bcb62568fb 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -2382,7 +2382,7 @@ static int skl_tplg_get_token(struct device *dev,
case SKL_TKN_U32_MAX_MCPS:
case SKL_TKN_U32_OBS:
case SKL_TKN_U32_IBS:
- ret = skl_tplg_fill_res_tkn(dev, tkn_elem, res, dir, pin_index);
+ ret = skl_tplg_fill_res_tkn(dev, tkn_elem, res, pin_index, dir);
if (ret < 0)
return ret;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index
2017-09-20 13:01 [PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index Colin King
@ 2017-09-22 10:13 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2017-09-22 10:13 UTC (permalink / raw)
To: Colin King
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Ramesh Babu, alsa-devel, kernel-janitors, linux-kernel
On Wed, Sep 20, 2017 at 02:01:25PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to slk_tplg_fill_res_tkn is passing dir and pin_index in the
> wrong order, they need to be in pin_index, dir order to match the function
> slk_tplg_fill_res_tkn correctly.
>
> Detected by CoveritScan, CID#1454992 ("Arguments in wrong order")
thanks for this.
Acked-By: Vinod Koul <vinod.koul@intel.com>
Tested-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-22 10:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 13:01 [PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index Colin King
2017-09-22 10:13 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).