From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: 陈华才 <chenhc@lemote.com>, "Christoph Hellwig" <hch@lst.de>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Fuxin Zhang" <zhangfx@lemote.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH V6 1/3] dma-mapping: Introduce device_is_coherent() as ahelper
Date: Fri, 22 Sep 2017 15:49:16 +0200 [thread overview]
Message-ID: <20170922134916.GA20335@lst.de> (raw)
In-Reply-To: <9213ab49-b6e6-d513-6d35-1fe2294aad68@arm.com>
On Fri, Sep 22, 2017 at 02:44:51PM +0100, Robin Murphy wrote:
> Not quite - I mean instead of adding an ops->device_is_coherent callback
> (which cannot really have a safe fallback value either way) and trying
> to enforce that dma_get_cache_alignment() should be the only valid
> caller, just add an ops->get_cache_alignment callback directly.
Exactly - and then fall back to ARCH_DMA_MINALIGN/1 if the ops vector
is not provided, to keep the existing behavior.
prev parent reply other threads:[~2017-09-22 13:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 8:52 [PATCH V6 1/3] dma-mapping: Introduce device_is_coherent() as a helper Huacai Chen
2017-09-19 8:52 ` [PATCH V6 2/3] dma-mapping: Rework dma_get_cache_alignment() function Huacai Chen
2017-09-19 15:02 ` Christoph Hellwig
2017-09-21 4:28 ` [PATCH V6 2/3] dma-mapping: Rework dma_get_cache_alignment()function 陈华才
2017-09-21 14:36 ` Christoph Hellwig
2017-09-19 8:52 ` [PATCH V6 3/3] scsi: Align block queue to dma_get_cache_alignment() Huacai Chen
2017-09-24 3:45 ` kbuild test robot
2017-09-21 10:47 ` [PATCH V6 1/3] dma-mapping: Introduce device_is_coherent() as a helper Robin Murphy
2017-09-22 2:13 ` [PATCH V6 1/3] dma-mapping: Introduce device_is_coherent() as ahelper 陈华才
2017-09-22 13:44 ` Robin Murphy
2017-09-22 13:49 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922134916.GA20335@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=chenhc@lemote.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).