From: Jonathan Cameron <jic23@kernel.org>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH 0/4] iio: light: vl6180: Several fixes and enhancements
Date: Sun, 24 Sep 2017 16:40:47 +0100 [thread overview]
Message-ID: <20170924164047.5f4869f5@archlinux> (raw)
In-Reply-To: <20170919031144.4968-1-stefan.bruens@rwth-aachen.de>
On Tue, 19 Sep 2017 05:11:40 +0200
Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:
> Currently, the vl6180 driver reports bogus in_illuminance_scale values
> when the integration time or hardware gain are changed from its default
> value, i.e. it always reports a fixed value.
>
> To avoid readback of the register values in case integration time, gain
> or scale is queried, save the register values. Use the saved values
> to report the correct scale value.
Hmm. I think unfortunately that this set is too large and invasive
to send as a fix. Hence once the little corners are tidied up I'll
take it via the slow path ready for the next merge window.
Thanks,
Jonathan
>
> Stefan Brüns (4):
> iio: light: vl6180: Move range check to integration time setter,
> cleanup
> iio: light: vl6180: Avoid readback of integration time register
> iio: light: vl6180: Cleanup als_gain lookup, avoid register readback
> iio: light: vl6180: Correct ALS scale for non-default gain/integration
> time
>
> drivers/iio/light/vl6180.c | 125 +++++++++++++++++++++++++--------------------
> 1 file changed, 69 insertions(+), 56 deletions(-)
>
prev parent reply other threads:[~2017-09-24 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 3:11 [PATCH 0/4] iio: light: vl6180: Several fixes and enhancements Stefan Brüns
2017-09-19 3:11 ` [PATCH 1/4] iio: light: vl6180: Move range check to integration time setter, cleanup Stefan Brüns
2017-09-19 6:17 ` Peter Meerwald-Stadler
2017-09-24 15:34 ` Jonathan Cameron
2017-09-19 3:11 ` [PATCH 2/4] iio: light: vl6180: Avoid readback of integration time register Stefan Brüns
2017-09-24 15:36 ` Jonathan Cameron
2017-09-19 3:11 ` [PATCH 3/4] iio: light: vl6180: Cleanup als_gain lookup, avoid register readback Stefan Brüns
2017-09-19 6:17 ` Peter Meerwald-Stadler
2017-09-19 3:11 ` [PATCH 4/4] iio: light: vl6180: Correct ALS scale for non-default gain/integration time Stefan Brüns
2017-09-24 15:40 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170924164047.5f4869f5@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stefan.bruens@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox