From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932737AbdIYGRh (ORCPT <rfc822;w@1wt.eu>);
        Mon, 25 Sep 2017 02:17:37 -0400
Received: from LGEAMRELO12.lge.com ([156.147.23.52]:59602 "EHLO
        lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932656AbdIYGRg (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 25 Sep 2017 02:17:36 -0400
X-Original-SENDERIP: 156.147.1.151
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 10.177.220.163
X-Original-MAILFROM: minchan@kernel.org
Date: Mon, 25 Sep 2017 15:17:34 +0900
From: Minchan Kim <minchan@kernel.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
        Rik van Riel <riel@redhat.com>, Shaohua Li <shli@kernel.org>,
        Hugh Dickins <hughd@google.com>, Fengguang Wu <fengguang.wu@intel.com>,
        Tim Chen <tim.c.chen@intel.com>, Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH] mm, swap: Make VMA based swap readahead configurable
Message-ID: <20170925061734.GA27678@bbox>
References: <20170921013310.31348-1-ying.huang@intel.com>
 <20170925054133.GB27410@bbox>
 <87bmlze319.fsf@yhuang-dev.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87bmlze319.fsf@yhuang-dev.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 25, 2017 at 01:54:42PM +0800, Huang, Ying wrote:
> Hi, Minchan,
> 
> Minchan Kim <minchan@kernel.org> writes:
> 
> > Hi Huang,
> >
> > On Thu, Sep 21, 2017 at 09:33:10AM +0800, Huang, Ying wrote:
> >> From: Huang Ying <ying.huang@intel.com>
> 
> [snip]
> 
> >> diff --git a/mm/Kconfig b/mm/Kconfig
> >> index 9c4bdddd80c2..e62c8e2e34ef 100644
> >> --- a/mm/Kconfig
> >> +++ b/mm/Kconfig
> >> @@ -434,6 +434,26 @@ config THP_SWAP
> >>  
> >>  	  For selection by architectures with reasonable THP sizes.
> >>  
> >> +config VMA_SWAP_READAHEAD
> >> +	bool "VMA based swap readahead"
> >> +	depends on SWAP
> >> +	default y
> >> +	help
> >> +	  VMA based swap readahead detects page accessing pattern in a
> >> +	  VMA and adjust the swap readahead window for pages in the
> >> +	  VMA accordingly.  It works better for more complex workload
> >> +	  compared with the original physical swap readahead.
> >> +
> >> +	  It can be controlled via the following sysfs interface,
> >> +
> >> +	    /sys/kernel/mm/swap/vma_ra_enabled
> >> +	    /sys/kernel/mm/swap/vma_ra_max_order
> >
> > It might be better to discuss in other thread but if you mention new
> > interface here again, I will discuss it here.
> >
> > We are creating new ABI in here so I want to ask question in here.
> >
> > Did you consier to use /sys/block/xxx/queue/read_ahead_kb for the
> > swap readahead knob? Reusing such common/consistent knob would be better
> > than adding new separate konb.
> 
> The problem is that the configuration of VMA based swap readahead is
> global instead of block device specific.  And because it works in
> virtual way, that is, the swap blocks on the different block devices may
> be readahead together.  It's a little hard to use the block device
> specific configuration.

Fair enough. page-cluster from the beginning should have been like that
instead of vma_ra_max_order.

One more questions: Do we need separate vma_ra_enable?

Can't we disable it via echo 0 > /sys/kernel/mm/swap/vma_ra_max_order
like page-cluster?