From: Christoph Hellwig <hch@infradead.org>
To: Rik van Riel <riel@surriel.com>
Cc: Gargi Sharma <gs051095@gmail.com>,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr,
akpm@linux-foundation.org, mingo@kernel.org,
pasha.tatashin@oracle.com, ktkhai@virtuozzo.com, oleg@redhat.com
Subject: Re: [PATCH 2/4] idr: Add a function idr_get()
Date: Mon, 25 Sep 2017 06:47:08 -0700 [thread overview]
Message-ID: <20170925134708.GA14314@infradead.org> (raw)
In-Reply-To: <1506345607.21121.81.camel@surriel.com>
On Mon, Sep 25, 2017 at 09:20:07AM -0400, Rik van Riel wrote:
> > +++ b/lib/idr.c
> > @@ -135,6 +135,17 @@ void *idr_get_next_ext(struct idr *idr, unsigned
> > long *nextid)
> > }
> > EXPORT_SYMBOL(idr_get_next_ext);
> >
> > +void * idr_get(struct idr *idr, int *id)
> > +{
> > + struct radix_tree_node *node;
> > + void __rcu **slot = NULL;
> > +
> > + __radix_tree_lookup(&idr->idr_rt, *id, &node, &slot);
> > + if (!slot)
> > + return NULL;
> > + return node;
> > +}
>
> I should have noticed this (much) earlier, but doesn't idr_get do
> essentially the same thing as idr_find?
>
> Also, wouldn't you want to return the pid pointer from slot,
> rather than a pointer to the entire radix tree node?
It also seems rather odd to pass id by reference here just to
dereference it a little later.
next prev parent reply other threads:[~2017-09-25 13:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 12:56 [PATCH 0/4] Replace PID bitmap with IDR API implementation Gargi Sharma
2017-09-25 12:56 ` [PATCH 1/4] pid: Replace pid bitmap implementation with IDR API Gargi Sharma
2017-09-25 13:09 ` Rik van Riel
2017-09-25 14:59 ` Oleg Nesterov
2017-09-25 17:41 ` Gargi Sharma
2017-09-25 15:20 ` Oleg Nesterov
2017-09-25 17:41 ` Gargi Sharma
2017-09-25 12:56 ` [PATCH 2/4] idr: Add a function idr_get() Gargi Sharma
2017-09-25 13:20 ` Rik van Riel
2017-09-25 13:47 ` Christoph Hellwig [this message]
2017-09-25 14:12 ` Oleg Nesterov
2017-09-25 17:43 ` Gargi Sharma
2017-09-25 12:56 ` [PATCH 3/4] pid.c: Replace pidhash lookup with idr_get() Gargi Sharma
2017-09-25 13:20 ` Rik van Riel
2017-09-25 17:44 ` Gargi Sharma
2017-09-25 19:30 ` Rik van Riel
2017-09-25 12:56 ` [PATCH 4/4] pid: Remove pidhash Gargi Sharma
2017-09-25 13:48 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925134708.GA14314@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=gs051095@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=pasha.tatashin@oracle.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox