From: Oleg Nesterov <oleg@redhat.com>
To: Gargi Sharma <gs051095@gmail.com>
Cc: linux-kernel@vger.kernel.org, riel@surriel.com,
julia.lawall@lip6.fr, akpm@linux-foundation.org,
mingo@kernel.org, pasha.tatashin@oracle.com,
ktkhai@virtuozzo.com
Subject: Re: [PATCH 1/4] pid: Replace pid bitmap implementation with IDR API
Date: Mon, 25 Sep 2017 17:20:27 +0200 [thread overview]
Message-ID: <20170925152027.GA12957@redhat.com> (raw)
In-Reply-To: <f5104f457ed581e0ac032a68af03c5ba5cb94755.1506342921.git.gs051095@gmail.com>
On 09/25, Gargi Sharma wrote:
>
> @@ -285,10 +145,14 @@ void free_pid(struct pid *pid)
> break;
> }
> }
> - spin_unlock_irqrestore(&pidmap_lock, flags);
>
> - for (i = 0; i <= pid->level; i++)
> - free_pidmap(pid->numbers + i);
> + for (i = 0; i <= pid->level; i++) {
> + struct upid *upid = pid->numbers + i;
> + struct pid_namespace *ns = upid->ns;
> +
> + idr_remove(&ns->idr, upid->nr);
> + }
> + spin_unlock_irqrestore(&pidmap_lock, flags);
Now that you moved the "free pidmap" code under pidmap_lock, we do not
need 2 "for (i = 0; i <= pid->level; i++)" loops, you could simply add
a single
idr_remove(&ns->idr, upid->nr);
line into the 1st loop ?
Oleg.
next prev parent reply other threads:[~2017-09-25 15:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 12:56 [PATCH 0/4] Replace PID bitmap with IDR API implementation Gargi Sharma
2017-09-25 12:56 ` [PATCH 1/4] pid: Replace pid bitmap implementation with IDR API Gargi Sharma
2017-09-25 13:09 ` Rik van Riel
2017-09-25 14:59 ` Oleg Nesterov
2017-09-25 17:41 ` Gargi Sharma
2017-09-25 15:20 ` Oleg Nesterov [this message]
2017-09-25 17:41 ` Gargi Sharma
2017-09-25 12:56 ` [PATCH 2/4] idr: Add a function idr_get() Gargi Sharma
2017-09-25 13:20 ` Rik van Riel
2017-09-25 13:47 ` Christoph Hellwig
2017-09-25 14:12 ` Oleg Nesterov
2017-09-25 17:43 ` Gargi Sharma
2017-09-25 12:56 ` [PATCH 3/4] pid.c: Replace pidhash lookup with idr_get() Gargi Sharma
2017-09-25 13:20 ` Rik van Riel
2017-09-25 17:44 ` Gargi Sharma
2017-09-25 19:30 ` Rik van Riel
2017-09-25 12:56 ` [PATCH 4/4] pid: Remove pidhash Gargi Sharma
2017-09-25 13:48 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925152027.GA12957@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gs051095@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox