From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965194AbdIYQGc (ORCPT ); Mon, 25 Sep 2017 12:06:32 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34033 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934503AbdIYQGa (ORCPT ); Mon, 25 Sep 2017 12:06:30 -0400 X-Google-Smtp-Source: AOwi7QCdtnQ6C8aPhZDvaaW4qe/TNSEYxm5ijn8OmHmqwBLf5u6eUzUBvZMFznrYmQTDlmjBwiGlzg== Date: Mon, 25 Sep 2017 18:06:27 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Mario Limonciello Cc: dvhart@infradead.org, LKML , platform-driver-x86@vger.kernel.org, quasisec@google.com Subject: Re: [PATCH 02/12] platform/x86: dell-wmi: Don't match on descriptor GUID modalias Message-ID: <20170925160627.GH22190@pali> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 21 September 2017 08:57:07 Mario Limonciello wrote: > The descriptor GUID is not used to indicate that WMI notifications > in the dell-wmi driver work properly. As such a modalias should > not be present that causes this driver to load on systems with this > GUID. Ok, understood. What we need there is to load driver in case both aliases are present in system. But I have no idea if kernel supports such logic. So, add my: Reviewed-by: Pali Rohár > Signed-off-by: Mario Limonciello > --- > drivers/platform/x86/dell-wmi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > index 28d9f8696081..1fbef560ca67 100644 > --- a/drivers/platform/x86/dell-wmi.c > +++ b/drivers/platform/x86/dell-wmi.c > @@ -51,7 +51,6 @@ MODULE_LICENSE("GPL"); > static bool wmi_requires_smbios_request; > > MODULE_ALIAS("wmi:"DELL_EVENT_GUID); > -MODULE_ALIAS("wmi:"DELL_DESCRIPTOR_GUID); > > struct dell_wmi_priv { > struct input_dev *input_dev; -- Pali Rohár pali.rohar@gmail.com