From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965571AbdIYSjJ convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Mon, 25 Sep 2017 14:39:09 -0400
Received: from mx2.suse.de ([195.135.220.15]:48023 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S933306AbdIYSjH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 25 Sep 2017 14:39:07 -0400
Date: Mon, 25 Sep 2017 20:39:01 +0200
From: Michal =?UTF-8?B?U3VjaMOhbmVr?= <msuchanek@suse.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Tamara Diaconita <diaconitatamara@gmail.com>,
        Baoquan He <bhe@redhat.com>,
        Kamlakant Patel <kamlakant.patel@broadcom.com>,
        Jonathan Corbet <corbet@lwn.net>, Jani Nikula <jani.nikula@intel.com>,
        Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
        Trond Myklebust <trond.myklebust@primarydata.com>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nicholas Piggin <npiggin@gmail.com>,
        Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Paul Mackerras <paulus@samba.org>,
        Hari Bathini <hbathini@linux.vnet.ibm.com>,
        Ilya Matveychikov <matvejchikov@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 1/6] lib/cmdline.c: Add backslash support to kernel
 commandline parsing.
Message-ID: <20170925203901.0009b327@naga>
In-Reply-To: <20170915192856.1d5708b6@kitsune.suse.cz>
References: <4fabdf584ad18d6aae61e331f783a5020567f634.1505231820.git.msuchanek@suse.de>
        <28da60231eb848981e858fa33e3b7e33f8547111.1505494668.git.msuchanek@suse.de>
        <20170915171409.GZ5426@ZenIV.linux.org.uk>
        <20170915192856.1d5708b6@kitsune.suse.cz>
X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-suse-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 15 Sep 2017 19:28:56 +0200
Michal Suchánek <msuchanek@suse.de> wrote:

> On Fri, 15 Sep 2017 18:14:09 +0100
> Al Viro <viro@ZenIV.linux.org.uk> wrote:
> 
> > On Fri, Sep 15, 2017 at 07:02:46PM +0200, Michal Suchanek wrote:
> >   
> > >  	for (i = 0; args[i]; i++) {
> > > -		if (isspace(args[i]) && !in_quote)
> > > +		if (isspace(args[i]) && !in_quote && !backslash)
> > >  			break;
> > > -		if (equals == 0) {
> > > -			if (args[i] == '=')
> > > -				equals = i;
> > > +
> > > +		if ((equals == 0) && (args[i] == '='))
> > > +			equals = i;
> > > +
> > > +		if (!backslash) {
> > > +			if ((args[i] == '"') || (args[i] ==
> > > '\\')) {
> > > +				if (args[i] == '"')
> > > +					in_quote = !in_quote;
> > > +				if (args[i] == '\\')
> > > +					backslash = 1;
> > > +
> > > +				memmove(args + 1, args, i);
> > > +				args++;
> > > +				i--;
> > > +			}
> > > +		} else {
> > > +			backslash = 0;
> > >  		}
> > > -		if (args[i] == '"')
> > > -			in_quote = !in_quote;
> > >  	}    
> > 
> > ... and that makes for Unidiomatic Work With Strings Award for this
> > September. Using memmove() for string rewrite is almost always bad
> > taste; in this case it's also (as usual) broken.  
> 
> Care to share how it is broken?

Guess not. I will assume it is perfectly fine then. It works perfectly
fine in my testing.

Using memmove for string rewrite is not a matter of taste. It is the
only library function with sane semantics for rewrite of anything. Then
again open-coding it is always an option and maybe in better taste for
some :->

Michal