Re: [PATCH 3/3] cgroup: Implement cgroup2 basic CPU usage accounting

Tejun Heo
2017-08-29T15:42:43Z

Hello, Waiman.

On Tue, Aug 29, 2017 at 11:32:35AM -0400, Waiman Long wrote:
> > Also, please note that a system may end up with a lot of cgroups
> > without the user intending to. memcg drains removed cgroups lazily
> > and the number of draining cgroups can reach very high numbers if the
> > system isn't under memory pressure. The plan is to add basic stats
> > for other resources too and keeping it scalable w.r.t. idle cgroups
> > allows using the same mechanism for all resources.
>
> I think it will be good to put the rationale behind this function as a
> comment in the code.

Ah, good point. I'll beef up the overall comment in the header file
and point to that from the function comment.

Thanks.

--
tejun