From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbdIYXLA (ORCPT ); Mon, 25 Sep 2017 19:11:00 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:53705 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753950AbdIYXK5 (ORCPT ); Mon, 25 Sep 2017 19:10:57 -0400 X-Google-Smtp-Source: AOwi7QA/rkXZr5iOHF8DGnW9frgtnZiZnFh8AKyYXjX7RsIyiheV3tWB41Rqo2fEsQWT8k9PERmmjg== Date: Mon, 25 Sep 2017 16:10:55 -0700 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Rafael Wysocki , Linux PM , Vincent Guittot , Pavel Machek , Len Brown , Linux Kernel Mailing List Subject: Re: [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire power directory Message-ID: <20170925231055.GA3053@ubuntu> References: <18e729501c1ebe4798d17b8d8a60ba102ebc2837.1505922834.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25-09-17, 00:44, Rafael J. Wysocki wrote: > On Wed, Sep 20, 2017 at 5:58 PM, Viresh Kumar wrote: > > The command: > > > > $ scripts/get_maintainer.pl -f drivers/base/power/opp/core.c > > > > is incorrectly picking maintainers from Hibernation and Suspend to RAM > > as well, simply because the entries in MAINTAINERS file contains the > > entire power directory. Though the only concerning file is main.c > > really. > > No, it is not the only one. The others are common.c, trace.c, > wakeup.c, wakeirq.c, sysfs.c, generic_ops.c and power.h (if I have not > overlooked any). > > I'm not actually sure how to fix this issue other than by listing all > of the files in question directly in there. Should I just use *.c for now? Yeah, that will still cover lot more files, but at least the directories, like OPP, are not going to show those maintainers. Or I was actually thinking of moving the entire OPP directory out of drivers/base/power, and move to drivers/opp, just like cpufreq and cpuidle. Will that be okay? -- viresh