Re: [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire power directory

Rafael J. Wysocki
2017-09-25T23:18:16Z

On Tue, Sep 26, 2017 at 1:10 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 25-09-17, 00:44, Rafael J. Wysocki wrote:
>> On Wed, Sep 20, 2017 at 5:58 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> > The command:
>> >
>> > $ scripts/get_maintainer.pl -f drivers/base/power/opp/core.c
>> >
>> > is incorrectly picking maintainers from Hibernation and Suspend to RAM
>> > as well, simply because the entries in MAINTAINERS file contains the
>> > entire power directory. Though the only concerning file is main.c
>> > really.
>>
>> No, it is not the only one. The others are common.c, trace.c,
>> wakeup.c, wakeirq.c, sysfs.c, generic_ops.c and power.h (if I have not
>> overlooked any).
>>
>> I'm not actually sure how to fix this issue other than by listing all
>> of the files in question directly in there.
>
> Should I just use *.c for now? Yeah, that will still cover lot more files, but
> at least the directories, like OPP, are not going to show those maintainers.
>
> Or I was actually thinking of moving the entire OPP directory out of
> drivers/base/power, and move to drivers/opp, just like cpufreq and cpuidle. Will
> that be okay?

Yes, that should be fine.