From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Kyle Huey <me@kylehuey.com>,
open list <linux-kernel@vger.kernel.org>,
"Robert O'Callahan" <robert@ocallahan.org>
Subject: Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat
Date: Mon, 25 Sep 2017 23:42:13 -0700 [thread overview]
Message-ID: <20170926064213.GA8473@infradead.org> (raw)
In-Reply-To: <CA+55aFxsRN02ZUPZF8txCemx7+bEWCkdKnrZpeJiyJe3r-Rn9w@mail.gmail.com>
On Mon, Sep 25, 2017 at 06:37:28PM -0700, Linus Torvalds wrote:
> Pulled and pushed out, but I'd like to note that sparse would have
> caught this. Except we are so far away from being sparse-clean that
> nobody runs it.
I tend to run sparse over the nvme code before sending pull request
every time. But it's a fairly new codebase, so it it actually
is clean. I wish we'd just default to running sparse at some point
so people have to clean their shit up, as it catches a lot of
useful things. But maybe for the default we want to tune it down
a bit (e.g. don't warn about missing statics by default, skip
the lock imbalance checks which while often useful also generate
tons of false positives).
next prev parent reply other threads:[~2017-09-26 6:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 22:18 Regression related to ipc shmctl compat Kyle Huey
2017-09-26 1:00 ` [git pull] vfs.git regression fix " Al Viro
2017-09-26 1:37 ` Linus Torvalds
2017-09-26 1:46 ` Al Viro
2017-09-26 2:00 ` Al Viro
2017-09-26 2:03 ` Linus Torvalds
2017-09-26 2:07 ` Linus Torvalds
2017-09-26 3:01 ` Al Viro
2017-09-26 19:45 ` Luc Van Oostenryck
2017-09-26 2:02 ` Linus Torvalds
2017-10-11 17:03 ` Al Viro
2017-10-11 17:06 ` Al Viro
2017-10-11 17:31 ` Linus Torvalds
2017-09-26 6:42 ` Christoph Hellwig [this message]
2017-09-28 6:13 ` Script to do smart sparse diffs (was Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat) Michael Ellerman
2017-10-15 6:58 ` [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat Pavel Machek
2017-10-16 11:41 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926064213.GA8473@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@kylehuey.com \
--cc=robert@ocallahan.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).