* [PATCH] IB/ocrdma: pr_err() strings should end with newlines
@ 2017-09-26 6:51 Arvind Yadav
2017-09-26 7:19 ` Yuval Shaia
2017-09-27 14:20 ` Doug Ledford
0 siblings, 2 replies; 5+ messages in thread
From: Arvind Yadav @ 2017-09-26 6:51 UTC (permalink / raw)
To: selvin.xavier, dledford, sean.hefty, hal.rosenstock
Cc: linux-rdma, linux-kernel
pr_err() messages should end with a new-line to avoid other messages
being concatenated.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
index 66056f9..e528d7a 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
@@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
if (reset) {
status = ocrdma_mbx_rdma_stats(dev, true);
if (status) {
- pr_err("Failed to reset stats = %d", status);
+ pr_err("Failed to reset stats = %d\n", status);
goto err;
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines
2017-09-26 6:51 [PATCH] IB/ocrdma: pr_err() strings should end with newlines Arvind Yadav
@ 2017-09-26 7:19 ` Yuval Shaia
2017-09-26 7:31 ` Arvind Yadav
2017-09-26 15:23 ` Joe Perches
2017-09-27 14:20 ` Doug Ledford
1 sibling, 2 replies; 5+ messages in thread
From: Yuval Shaia @ 2017-09-26 7:19 UTC (permalink / raw)
To: Arvind Yadav
Cc: selvin.xavier, dledford, sean.hefty, hal.rosenstock, linux-rdma,
linux-kernel
On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> index 66056f9..e528d7a 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
> if (reset) {
> status = ocrdma_mbx_rdma_stats(dev, true);
> if (status) {
> - pr_err("Failed to reset stats = %d", status);
> + pr_err("Failed to reset stats = %d\n", status);
> goto err;
> }
> }
While there, can you also fix line 1096 in ocrdma_hw.c?
(is it too naive to expect checkptahc to catch such errors?)
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines
2017-09-26 7:19 ` Yuval Shaia
@ 2017-09-26 7:31 ` Arvind Yadav
2017-09-26 15:23 ` Joe Perches
1 sibling, 0 replies; 5+ messages in thread
From: Arvind Yadav @ 2017-09-26 7:31 UTC (permalink / raw)
To: Yuval Shaia
Cc: selvin.xavier, dledford, sean.hefty, hal.rosenstock, linux-rdma,
linux-kernel
Hi Yuval,
On Tuesday 26 September 2017 12:49 PM, Yuval Shaia wrote:
> On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote:
>> pr_err() messages should end with a new-line to avoid other messages
>> being concatenated.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
>> index 66056f9..e528d7a 100644
>> --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
>> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
>> @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
>> if (reset) {
>> status = ocrdma_mbx_rdma_stats(dev, true);
>> if (status) {
>> - pr_err("Failed to reset stats = %d", status);
>> + pr_err("Failed to reset stats = %d\n", status);
>> goto err;
>> }
>> }
> While there, can you also fix line 1096 in ocrdma_hw.c?
>
> (is it too naive to expect checkptahc to catch such errors?)
As per your suggestion, I have done the changes.
>
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
~arvind
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines
2017-09-26 7:19 ` Yuval Shaia
2017-09-26 7:31 ` Arvind Yadav
@ 2017-09-26 15:23 ` Joe Perches
1 sibling, 0 replies; 5+ messages in thread
From: Joe Perches @ 2017-09-26 15:23 UTC (permalink / raw)
To: Yuval Shaia, Arvind Yadav
Cc: selvin.xavier, dledford, sean.hefty, hal.rosenstock, linux-rdma,
linux-kernel
On Tue, 2017-09-26 at 10:19 +0300, Yuval Shaia wrote:
> On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote:
> > pr_err() messages should end with a new-line to avoid other messages
> > being concatenated.
[]
> > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
[]
> > @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
> > if (reset) {
> > status = ocrdma_mbx_rdma_stats(dev, true);
> > if (status) {
> > - pr_err("Failed to reset stats = %d", status);
> > + pr_err("Failed to reset stats = %d\n", status);
> > goto err;
> > }
> > }
>
> While there, can you also fix line 1096 in ocrdma_hw.c?
>
> (is it too naive to expect checkptahc to catch such errors?)
Yes. It is not reasonable.
There would be way too high a false positive rate
as checkpatch could not trace whether or not there
is a printk(KERN_CONT or pr_cont after that.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines
2017-09-26 6:51 [PATCH] IB/ocrdma: pr_err() strings should end with newlines Arvind Yadav
2017-09-26 7:19 ` Yuval Shaia
@ 2017-09-27 14:20 ` Doug Ledford
1 sibling, 0 replies; 5+ messages in thread
From: Doug Ledford @ 2017-09-27 14:20 UTC (permalink / raw)
To: Arvind Yadav, selvin.xavier, sean.hefty, hal.rosenstock
Cc: linux-rdma, linux-kernel
On Tue, 2017-09-26 at 12:21 +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-27 14:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-26 6:51 [PATCH] IB/ocrdma: pr_err() strings should end with newlines Arvind Yadav
2017-09-26 7:19 ` Yuval Shaia
2017-09-26 7:31 ` Arvind Yadav
2017-09-26 15:23 ` Joe Perches
2017-09-27 14:20 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox