From: Jean Delvare <jdelvare@suse.de>
To: <sean.wang@mediatek.com>
Cc: <matthias.bgg@gmail.com>, <linux-mediatek@lists.infradead.org>,
<arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: mediatek: turn MTK_PMIC_WRAP into visible symbols
Date: Tue, 26 Sep 2017 08:00:22 +0200 [thread overview]
Message-ID: <20170926080022.215f7b7b@endymion> (raw)
In-Reply-To: <6c1696cf9f860cc8151a906ecbc799121b5aeeab.1505984256.git.sean.wang@mediatek.com>
On Thu, 21 Sep 2017 17:01:05 +0800, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> MTK_PMIC_WRAP is the basic and required configuration for those various
> MediaTek PMICs, so turning MTK_PMIC_WRAP into visible symbols easily
> allows users tending to have the enablement for those PMICs.
I can't really make sense of the sentence above, sorry, and can't see
how it matches the change below anyway. MTK_PMIC_WRAP is already a
visible symbol before this change. The change is probably good in
itself, but please try to come up with a better description.
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
> drivers/soc/mediatek/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> index a2fcd7f..d513629 100644
> --- a/drivers/soc/mediatek/Kconfig
> +++ b/drivers/soc/mediatek/Kconfig
> @@ -15,7 +15,7 @@ config MTK_INFRACFG
> config MTK_PMIC_WRAP
> tristate "MediaTek PMIC Wrapper Support"
> depends on ARCH_MEDIATEK
> - depends on RESET_CONTROLLER
> + select RESET_CONTROLLER
> select REGMAP
> help
> Say yes here to add support for MediaTek PMIC Wrapper found
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2017-09-26 6:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 9:01 [PATCH] soc: mediatek: turn MTK_PMIC_WRAP into visible symbols sean.wang
2017-09-26 6:00 ` Jean Delvare [this message]
2017-10-02 11:21 ` Arnd Bergmann
2017-10-05 6:33 ` Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926080022.215f7b7b@endymion \
--to=jdelvare@suse.de \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox