From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970006AbdIZS0L (ORCPT ); Tue, 26 Sep 2017 14:26:11 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:47926 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967715AbdIZS0J (ORCPT ); Tue, 26 Sep 2017 14:26:09 -0400 X-Google-Smtp-Source: AOwi7QALLoTzHPpzDmhpzhgi6ZFqUkWsMXL1BFRWLQ2cXTpiDOZzkuyZhGQ6wqawZsoNTJYOkocnHQ== Date: Tue, 26 Sep 2017 21:26:04 +0300 From: Alexey Dobriyan To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: maninder1.s@samsung.com, andi@firstfloor.org, a.sahrawat@samsung.com, mmarek@suse.cz, pankaj.m@samsung.com, v.narang@samsung.com Subject: Re: + bloat-o-meter-provide-3-different-arguments-for-data-function-and-all.patch added to -mm tree Message-ID: <20170926182604.GA14724@avx2> References: <59c99971.JBsNlE1PhnN3+sL6%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59c99971.JBsNlE1PhnN3+sL6%akpm@linux-foundation.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 25, 2017 at 05:04:01PM -0700, akpm@linux-foundation.org wrote: > +def getsizes(file, format) : > + func_sym = {} > + for l in os.popen("nm --size-sort " + file).readlines(): This simply undoes "for line in f" optimization I did. > +if(sys.argv[1] == "-c"): > +elif(sys.argv[1] == "-d"): > +elif(sys.argv[1] == "-t"): Python doesn't require () here. In general output is pretty noisy already and all those "#######" do not help. A