From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936761AbdIZUME (ORCPT ); Tue, 26 Sep 2017 16:12:04 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:50815 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935367AbdIZUMA (ORCPT ); Tue, 26 Sep 2017 16:12:00 -0400 X-Google-Smtp-Source: AOwi7QCEyBlSjdmenDK3TfKL+/cy/V4PSSKL4s7mrfsJIz0LWaSjKSu+T1qXDRN9S59Fa2qAAIUEJg== From: Pali =?utf-8?q?Roh=C3=A1r?= To: Mario Limonciello Subject: Re: [PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi descriptor check Date: Tue, 26 Sep 2017 22:11:56 +0200 User-Agent: KMail/1.13.7 (Linux/3.13.0-117-generic; KDE/4.14.2; x86_64; ; ) Cc: dvhart@infradead.org, Andy Shevchenko , LKML , platform-driver-x86@vger.kernel.org, quasisec@google.com References: <4178d2bdfc69c94fe4972fee7b97b08202890e66.1506451187.git.mario.limonciello@dell.com> In-Reply-To: <4178d2bdfc69c94fe4972fee7b97b08202890e66.1506451187.git.mario.limonciello@dell.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart14356241.LFkene8jV0"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201709262211.57222@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart14356241.LFkene8jV0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tuesday 26 September 2017 20:50:12 Mario Limonciello wrote: > + if (strncmp(obj->string.pointer, "DELL WMI", 8) !=3D 0) Should not be this memcmp? IIRC we want to compare that buffer is equal=20 to some bytes, right? =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart14356241.LFkene8jV0 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlnKtI0ACgkQi/DJPQPkQ1Ir2gCgoXxyQJCN+uDsCeHQzaZBh3Kk uAQAoJTED+mNA2waVl34aQvkcJodZCxr =11yG -----END PGP SIGNATURE----- --nextPart14356241.LFkene8jV0--