From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970226AbdIZT0o (ORCPT ); Tue, 26 Sep 2017 15:26:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52182 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965192AbdIZT0l (ORCPT ); Tue, 26 Sep 2017 15:26:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8216215552 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mst@redhat.com Date: Tue, 26 Sep 2017 22:26:40 +0300 From: "Michael S. Tsirkin" To: Jason Wang Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH net-next RFC 0/5] batched tx processing in vhost_net Message-ID: <20170926222528-mutt-send-email-mst@kernel.org> References: <1506067355-5771-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506067355-5771-1-git-send-email-jasowang@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 26 Sep 2017 19:26:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 22, 2017 at 04:02:30PM +0800, Jason Wang wrote: > Hi: > > This series tries to implement basic tx batched processing. This is > done by prefetching descriptor indices and update used ring in a > batch. This intends to speed up used ring updating and improve the > cache utilization. Test shows about ~22% improvement in tx pss. > Please review. > > Jason Wang (5): > vhost: split out ring head fetching logic > vhost: introduce helper to prefetch desc index > vhost: introduce vhost_add_used_idx() Please squash these new APIs into where they are used. This split-up just makes review harder for me as I can't figure out how the new APIs are used. > vhost_net: rename VHOST_RX_BATCH to VHOST_NET_BATCH This is ok as a separate patch. > vhost_net: basic tx virtqueue batched processing > > drivers/vhost/net.c | 221 ++++++++++++++++++++++++++++---------------------- > drivers/vhost/vhost.c | 165 +++++++++++++++++++++++++++++++------ > drivers/vhost/vhost.h | 9 ++ > 3 files changed, 270 insertions(+), 125 deletions(-) > > -- > 2.7.4