From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2 2/6] perf record: Get the first sample time and last sample time
Date: Wed, 27 Sep 2017 14:16:14 +0200 [thread overview]
Message-ID: <20170927121614.GA563@krava> (raw)
In-Reply-To: <1506423482-16894-3-git-send-email-yao.jin@linux.intel.com>
On Tue, Sep 26, 2017 at 06:57:58PM +0800, Jin Yao wrote:
> In perf record, it's walked on all samples yet. So it's very easy to get
> the first/last samples and save the time to perf file header via the
> function write_sample_time().
>
> In later, perf report/script will fetch the time from perf file header.
>
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> ---
> tools/perf/builtin-record.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 9b379f3..3428633 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -80,6 +80,8 @@ struct record {
> bool timestamp_filename;
> struct switch_output switch_output;
> unsigned long long samples;
> + u64 first_sample_time;
> + u64 last_sample_time;
so we have those 2 u64 already in 3 structs: evlist, session and now record
can't we do that with just in one? I'd think all of them should be available
and reachable everywhere
jirka
next prev parent reply other threads:[~2017-09-27 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 10:57 [PATCH v2 0/6] perf report/script: Support percent and multiple range in --time option Jin Yao
2017-09-26 10:57 ` [PATCH v2 1/6] perf header: Record first sample time and last sample time in perf file header Jin Yao
2017-09-26 10:57 ` [PATCH v2 2/6] perf record: Get the first sample time and last sample time Jin Yao
2017-09-27 12:16 ` Jiri Olsa [this message]
2017-09-27 13:00 ` Jin, Yao
2017-09-26 10:57 ` [PATCH v2 3/6] perf util: Create function to parse time percent Jin Yao
2017-09-27 12:23 ` Jiri Olsa
2017-09-26 10:58 ` [PATCH v2 4/6] perf util: Create function to perform multiple time range checking Jin Yao
2017-09-26 10:58 ` [PATCH v2 5/6] perf report: support time percent and multiple time ranges Jin Yao
2017-09-26 10:58 ` [PATCH v2 6/6] perf script: " Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927121614.GA563@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox