From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752760AbdI0MX0 (ORCPT ); Wed, 27 Sep 2017 08:23:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51710 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411AbdI0MXZ (ORCPT ); Wed, 27 Sep 2017 08:23:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ABBE925C2A Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Wed, 27 Sep 2017 14:23:21 +0200 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v2 3/6] perf util: Create function to parse time percent Message-ID: <20170927122321.GA1530@krava> References: <1506423482-16894-1-git-send-email-yao.jin@linux.intel.com> <1506423482-16894-4-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506423482-16894-4-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 27 Sep 2017 12:23:25 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 26, 2017 at 06:57:59PM +0800, Jin Yao wrote: SNIP > + > + if (p2) > + p1 = p2 + 1; > + else > + break; > + } > + > + free(str); > + return i; > +} > + > +int perf_time__percent_parse_str(struct perf_time_interval *ptime_buf, int num, > + const char *ostr, u64 start, u64 end) > +{ this function is perfect for automated test ;-) jirka