From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752838AbdI0NP0 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 27 Sep 2017 09:15:26 -0400
Received: from mail-pf0-f193.google.com ([209.85.192.193]:33877 "EHLO
        mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751959AbdI0NPY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 27 Sep 2017 09:15:24 -0400
X-Google-Smtp-Source: AOwi7QAOn8mXS6Dp8kODUji9xoJzMMosouJr3OG0oFkIwz7RZx30MT7gqOdMqBJcdOdyqQQ+J17zXw==
Date: Wed, 27 Sep 2017 22:15:11 +0900
From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: "Huang, Ying" <ying.huang@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
        Rik van Riel <riel@redhat.com>, Shaohua Li <shli@kernel.org>,
        Hugh Dickins <hughd@google.com>, Fengguang Wu <fengguang.wu@intel.com>,
        Tim Chen <tim.c.chen@intel.com>, Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH] mm, swap: Make VMA based swap readahead configurable
Message-ID: <20170927131511.GA338@bgram>
References: <20170921013310.31348-1-ying.huang@intel.com>
 <20170926132129.dbtr2mof35x4j4og@dhcp22.suse.cz>
 <20170927050401.GA715@bbox>
 <20170927074835.37m4dclmew5ecli2@dhcp22.suse.cz>
 <20170927080432.GA1160@bbox>
 <20170927083512.dydqlqezh5polggb@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170927083512.dydqlqezh5polggb@dhcp22.suse.cz>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 27, 2017 at 10:35:12AM +0200, Michal Hocko wrote:
> On Wed 27-09-17 17:04:32, Minchan Kim wrote:
> > On Wed, Sep 27, 2017 at 09:48:35AM +0200, Michal Hocko wrote:
> > > On Wed 27-09-17 14:04:01, Minchan Kim wrote:
> [...]
> > > > The problem is users have disabled swap readahead by echo 0 > /proc/sys/
> > > > vm/page-cluster are regressed by this new interface /sys/kernel/mm/swap/
> > > > vma_ra_max_order. Because for disabling readahead completely, they should
> > > > disable vma_ra_max_order as well as page-cluster from now on.
> > > > 
> > > > So, goal of new config to notice new feature to admins so they can be aware
> > > > of new konb vma_ra_max_order as well as page-cluster.
> > > > I canont think other better idea to preventing such regression.
> > > > 
> > > > http://lkml.kernel.org/r/%3C20170913014019.GB29422@bbox%3E
> > > 
> > > So, how are you going to configure this when you do not know whether
> > > zram will be used? In other words what should e.g. distribution set this
> > > to?
> > 
> > I have no idea. Unfortunately, it depends on them. If they want to use
> > zram as swap, they should fix the script. Surely, I don't like it.
> > Instead, I wanted that page-cluster zeroing disables both virtual/pysical
> > swap readahead not to break current userspace. However, Huang doesn't
> > liek it.
> > If you have better idea, please suggest.
> 
> I understand your frustration but config options are not there to bypass
> proper design decisions. Why cannot we unconditionally disable all the
> read ahead when zram is enabled?

It's not a zram specific issue. Every users who have disabled swap readahead
via page-cluster will be broken, too.