From: Darren Hart <dvhart@infradead.org>
To: Mario Limonciello <mario.limonciello@dell.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org, quasisec@google.com,
pali.rohar@gmail.com
Subject: Re: [PATCH v2 02/14] platform/x86: dell-smbios: drop needless includes
Date: Wed, 27 Sep 2017 10:40:19 -0700 [thread overview]
Message-ID: <20170927174019.GJ23572@fury> (raw)
In-Reply-To: <cc9ebe36b3c0adee5789253b6d77a2a5e3a7e765.1506451187.git.mario.limonciello@dell.com>
On Tue, Sep 26, 2017 at 01:50:00PM -0500, Mario Limonciello wrote:
> These aren't needed to compile the module.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
Hrm...
CONFIG_DELL_SMBIOS=m
$ make drivers/platform/x86/dell-smbios.ko
CC [M] drivers/platform/x86/dell-smbios.o
drivers/platform/x86/dell-smbios.c: In function ‘parse_da_table’:
drivers/platform/x86/dell-smbios.c:142:18: error: implicit declaration of function ‘krealloc’ [-Werror=implicit-function-declaration]
new_da_tokens = krealloc(da_tokens, (da_num_tokens + tokens) *
^~~~~~~~
drivers/platform/x86/dell-smbios.c:142:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
new_da_tokens = krealloc(da_tokens, (da_num_tokens + tokens) *
^
drivers/platform/x86/dell-smbios.c: In function ‘dell_smbios_init’:
drivers/platform/x86/dell-smbios.c:193:2: error: implicit declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
kfree(da_tokens);
^~~~~
> ---
> drivers/platform/x86/dell-smbios.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
> index 0a5723468bff..6654ad44a04c 100644
> --- a/drivers/platform/x86/dell-smbios.c
> +++ b/drivers/platform/x86/dell-smbios.c
> @@ -17,10 +17,7 @@
> #include <linux/module.h>
> #include <linux/dmi.h>
> #include <linux/err.h>
> -#include <linux/gfp.h>
> #include <linux/mutex.h>
> -#include <linux/slab.h>
Appears you do require slab.h...
> -#include <linux/io.h>
> #include "../../firmware/dcdbas.h"
> #include "dell-smbios.h"
>
> --
> 2.14.1
>
>
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-09-27 17:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 18:49 [PATCH v2 00/14] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-09-26 18:49 ` [PATCH v2 01/14] platform/x86: dell-wmi: label driver as handling notifications Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 02/14] platform/x86: dell-smbios: drop needless includes Mario Limonciello
2017-09-27 17:40 ` Darren Hart [this message]
2017-09-27 17:44 ` Mario.Limonciello
2017-09-27 17:58 ` Darren Hart
2017-09-29 14:59 ` kbuild test robot
2017-09-26 18:50 ` [PATCH v2 03/14] platform/x86: dell-wmi: Don't match on descriptor GUID modalias Mario Limonciello
2017-09-27 17:21 ` Darren Hart
2017-09-27 17:30 ` Mario.Limonciello
2017-09-27 17:44 ` Darren Hart
2017-09-26 18:50 ` [PATCH v2 04/14] platform/x86: dell-smbios: Add pr_fmt definition to driver Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 05/14] platform/x86: wmi: sort include list Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 06/14] platform/x86: wmi: Cleanup exit routine in reverse order of init Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 07/14] platform/x86: wmi: destroy on cleanup rather than unregister Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 08/14] platform/x86: dell-smbios: Introduce a WMI-ACPI interface Mario Limonciello
2017-09-27 22:18 ` Darren Hart
2017-09-26 18:50 ` [PATCH v2 09/14] platform/x86: dell-smbios: rename to dell-wmi-smbios Mario Limonciello
2017-09-26 20:06 ` Pali Rohár
2017-09-26 20:18 ` Mario.Limonciello
2017-09-27 22:30 ` Darren Hart
2017-09-29 14:53 ` kbuild test robot
2017-09-29 15:33 ` kbuild test robot
2017-09-26 18:50 ` [PATCH v2 10/14] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 11/14] platform/x86: wmi: create character devices when requested by drivers Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 12/14] platform/x86: dell-wmi-smbios: introduce character device for userspace Mario Limonciello
2017-09-26 19:04 ` Andy Shevchenko
2017-09-26 20:10 ` Pali Rohár
2017-09-26 20:16 ` Mario.Limonciello
2017-09-26 18:50 ` [PATCH v2 13/14] platform/x86: Kconfig: Change the default settings for dell-wmi-smbios Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi descriptor check Mario Limonciello
2017-09-26 20:11 ` Pali Rohár
2017-09-26 20:19 ` Mario.Limonciello
2017-09-26 19:05 ` [PATCH v2 00/14] Introduce support for Dell SMBIOS over WMI Andy Shevchenko
2017-09-26 19:17 ` Mario.Limonciello
2017-09-27 17:11 ` Darren Hart
2017-09-27 17:31 ` Mario.Limonciello
2017-09-27 17:36 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927174019.GJ23572@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quasisec@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox