Re: [PATCH v6 4/4] x86/tsc: use tsc early

Pasha Tatashin
2017-08-30T21:33:38Z

Hi Fenghua,

Thank you for looking at this. Unfortunately I can't mark either of them
__init because sched_clock_early() is called from
u64 sched_clock_cpu(int cpu)

Which is around for the live of the system.

Thank you,
Pasha

On 08/30/2017 05:21 PM, Fenghua Yu wrote:
> On Wed, Aug 30, 2017 at 02:12:09PM -0700, Fenghua Yu wrote:
>> +static struct cyc2ns_data cyc2ns_early;
>> +static bool sched_clock_early_enabled;
>
> Should these two varaibles be "__initdata"?
>
>> +u64 sched_clock_early(void)
> This function is only called during boot time. Should it
> be a "__init" function?
>
> Thanks.
>
> -Fenghua
>