From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751847AbdI0T71 (ORCPT ); Wed, 27 Sep 2017 15:59:27 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:35680 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbdI0T70 (ORCPT ); Wed, 27 Sep 2017 15:59:26 -0400 Date: Wed, 27 Sep 2017 21:59:22 +0200 From: Sam Ravnborg To: Vijay Kumar Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, babu.moger@oracle.com, rob.gardner@oracle.com Subject: Re: [PATCH v2 1/2] sparc64: Define SPARC default fls and __fls Message-ID: <20170927195922.GA22664@ravnborg.org> References: <1506540326-9604-1-git-send-email-vijay.ac.kumar@oracle.com> <1506540326-9604-2-git-send-email-vijay.ac.kumar@oracle.com> <20170927195043.GA15193@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170927195043.GA15193@ravnborg.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.2 cv=eqGd9chX c=1 sm=1 tr=0 a=Ij76tQDYWdb01v2+RnYW5w==:117 a=Ij76tQDYWdb01v2+RnYW5w==:17 a=kj9zAlcOel0A:10 a=31tsVcWsjbqEky76TD4A:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + > > +EXPORT_SYMBOL(__fls) > > +EXPORT_SYMBOL(fls) > > + > > +fls: > Use ENTRY(), ENDPROC() for assembler functions. And locate EXPORT_SYMBOL() right after ENDPROC(). Sam