From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752255AbdI0Wa1 (ORCPT ); Wed, 27 Sep 2017 18:30:27 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:51866 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbdI0WaZ (ORCPT ); Wed, 27 Sep 2017 18:30:25 -0400 Date: Wed, 27 Sep 2017 15:30:23 -0700 From: Darren Hart To: Mario.Limonciello@dell.com Cc: pali.rohar@gmail.com, andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, quasisec@google.com Subject: Re: [PATCH v2 09/14] platform/x86: dell-smbios: rename to dell-wmi-smbios Message-ID: <20170927223023.GR23572@fury> References: <746fb34ff44824808e7892f81247436f80c7ab83.1506451187.git.mario.limonciello@dell.com> <201709262206.13177@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 26, 2017 at 08:18:54PM +0000, Mario.Limonciello@dell.com wrote: > > -----Original Message----- > > From: Pali Rohár [mailto:pali.rohar@gmail.com] > > Sent: Tuesday, September 26, 2017 4:06 PM > > To: Limonciello, Mario > > Cc: dvhart@infradead.org; Andy Shevchenko ; > > LKML ; platform-driver-x86@vger.kernel.org; > > quasisec@google.com > > Subject: Re: [PATCH v2 09/14] platform/x86: dell-smbios: rename to dell-wmi- > > smbios > > > > On Tuesday 26 September 2017 20:50:07 Mario Limonciello wrote: > > > This follows the style of the rest of the platform x86 WMI drivers. > > > > > > Renaming the driver requires adjusting the other drivers using > > > dell-smbios to pick up the newly named includes. > > > > > > While renaming, I noticed that this driver was missing from > > > MAINTAINERS. Add it to that and myself to the list of people > > > maintaing it. > > > > > > Signed-off-by: Mario Limonciello > > > > Now when driver supports both old and new WMI call interface, I think > > that renaming is not needed... > > > > So all other drivers that use WMI have "WMI" in the name, this would be > breaking previously set precedence. Daren, Andy, what would you like > me to do? I'm leaning toward Pali's point of view here. In fact, I think the driver name should reflect WHAT it does as opposed to HOW it does it. vendor-hotkeys is a much better name than vendor-wmi. We have a lot of drivers that are not nicely granular and use more generic terms like -acpi or -laptop, but those shouldn't be the first choice in my opinion. Now, is SMBIOS any better than WMI? :-) Not really, but it is at least as good as, and less change makes it the winner IMO. -- Darren Hart VMware Open Source Technology Center